[build] Fix issue between reproducible build and dood. (#11084) #12845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushilongbuaa
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
xumia
approved these changes
Nov 28, 2022
|
@liushilongbuaa , please add more comments in the description, thanks. |
liushilongbuaa
added
Request for 202106 Branch
Request for 202111 Branch
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 28, 2022
|
Cherry-pick PR to 202211: #12851 |
mssonicbld
added a commit
that referenced
this pull request
Nov 29, 2022
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 21, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 21, 2022
|
Cherry-pick PR to 202106: #13120 |
|
Cherry-pick PR to 202111: #13121 |
This was referenced Dec 21, 2022
mssonicbld
added a commit
that referenced
this pull request
Dec 21, 2022
mssonicbld
pushed a commit
that referenced
this pull request
Jan 6, 2023
mssonicbld
added
Included in 202111 Branch
and removed
Request for 202111 Branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
dood PR renamed docker image with a tail '-sonic'. It affects reproducible build version file's name, which makes version pinning not work.
Now it blocks 202211 branch vs platform's build for target/docker-sonic-vs.gz
How I did it
Remove the tail when collecting version information step.
It has been verified by 202205 branch.
How to verify it
check target/versions to see the file name.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)