Enable SAI thrift for Mellanox platform #1288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andrii, I've pushed my changes enabling building the libsaithrift-dev library in the following PR: #1296 |
|
retest this please |
andrii-savka
force-pushed
the
enable_saithrift_mellanox
branch
from
f2ccb24
to
5154229
Compare
|
Retested and updated based on #1296 |
|
added for all platforms, no longer needed for this pr. |
mssonicbld
added a commit
that referenced
this pull request
Sep 26, 2023
…tically (#16168) #### Why I did it src/sonic-sairedis ``` * c22b76b - (HEAD -> master, origin/master, origin/HEAD) [VOQ][saidump] Enhance saidump with new option -r to parser the JSON file and displays/format the right output (#1288) (17 hours ago) [JunhongMao] * 31bd92a - Add log for git revision (#1293) (4 days ago) [Kamil Cudnik] * edf6597 - [submodule] Update SAI submodule to v1.13 (#1292) (6 days ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Enable SAI thrift in RPC image for Mellanox platform
- How I did it
Changed MLNX platforms related makefiles to enable SAI thrift
- How to verify it
Build and check if syncd process has a "-r" and "-m" flags.
Check the SAI thrift listening socket.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)