Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CPLD and FPGA driver framework module complies with s3ip sysfs sp… #12891

Merged

Conversation

tianshangfei
Copy link
Contributor

@tianshangfei tianshangfei commented Nov 30, 2022

…ecification

Signed-off-by: tianshangfei tian_shangfei@163.com

Why I did it

Provide CPLD and FPGA driver framework that complies with s3ip sysfs specification

How I did it

1、 The framework module provides register and unregister interface and implementation.
2、 The framework will help you create the sysfs node

How to verify it

A demo driver base on this framework will display the sysfs node wich conform to the s3ip sysfs specification

Which release branch to backport (provide reason below if selected)

The s3ip framework

  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…ecification

Signed-off-by: tianshangfei <tian_shangfei@163.com>
@adyeung
Copy link
Collaborator

adyeung commented Nov 30, 2022

@FuzailBrcm pls help review

Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@StormLiangMS
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit a2885b3 into sonic-net:master Dec 16, 2022
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 1, 2023
…ecification (sonic-net#12891)

Why I did it
Provide CPLD and FPGA driver framework that complies with s3ip sysfs specification

How I did it
1、 The framework module provides register and unregister interface and implementation.
2、 The framework will help you create the sysfs node

How to verify it
A demo driver base on this framework will display the sysfs node wich conform to the s3ip sysfs specification
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #13218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants