-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The user framework module complies with s3ip sysfs specification #12894
Conversation
Signed-off-by: tianshangfei <tian_shangfei@163.com>
@FuzailBrcm pls help review |
"path": "/sys_switch/temp_sensor", | ||
"type" : "path", | ||
"value" : "/sys/s3ip/temp_sensor", | ||
"description": "温度传感器信息" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These descriptions are being shown in Mandarin. Can you change it to english pls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it has been modified
"description": "ONIE EEPROM" | ||
}, | ||
{ | ||
"path": "/sys_switch/fan", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if a platform drivers are already loaded and path to read fan_speed is
/sys/bus/i2c/devices/x-00y/fan<>_input
How can we mention this in the JSON file? Can you give an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example you want is shown below,
{
"path": "/sys_switch/fan/fan1/motor0/speed",
"type" : "path",
"value" : "/sys/bus/i2c/devices/x-00y/fan<>_input",
"description": "the motor0 of fan1 speed information"
},
Generally speaking, is it possible to link (via softlinks) the S3IP framework SysFS to the SysFS created by the BSP drivers? If yes, how? |
Signed-off-by: tianshangfei <tian_shangfei@163.com>
Ok. For example, if the LED driver is based on the kernel framework of S3IP, the framework will automatically create the path /sys/s3ip/sysled. The kernel framework helps you create legitimate hardware information attributes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
…ic-net#12894) Why I did it The user framework module complies with s3ip sysfs specification How I did it 1、 create a s3ip_sysfs service 2、 the s3ip_sysfs service call the “s3ip_sysfs_tool.sh” to install kernel module and run s3ip_load.py 3、 s3ip_load.py will parse the s3ip_sysfs_conf.json configuration file and create /sys_switch/ directory How to verify it A demo driver base on this framework will display the sysfs node wich conform to the s3ip sysfs specification
Cherry-pick PR to 202211: #13215 |
Signed-off-by: tianshangfei tian_shangfei@163.com
Why I did it
The user framework module complies with s3ip sysfs specification
How I did it
1、 create a s3ip_sysfs service
2、 the s3ip_sysfs service call the “s3ip_sysfs_tool.sh” to install kernel module and run s3ip_load.py
3、 s3ip_load.py will parse the s3ip_sysfs_conf.json configuration file and create /sys_switch/ directory
How to verify it
A demo driver base on this framework will display the sysfs node which conforms to the s3ip sysfs specification
Which release branch to backport (provide reason below if selected)
The s3ip framework
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)