Fix docker load image tag not being the expected tag #12959
Conversation
PR sonic-net#12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
|
Hi @saiarcot895, do you know why only docker-dhcp-relay and docker-macsec are added in SONIC_PACKAGES_LOCAL? ./rules/docker-dhcp-relay.mk:43:SONIC_PACKAGES_LOCAL += $(DOCKER_DHCP_RELAY) |
|
@saiarcot895 It seems that 202205 didn't need this PR. 202211 needs it. |
It's part of application extension images. The idea is that these docker containers (and probably some others, just that they aren't supported yet) can be individually installed or upgraded to newer versions.
Oh that's odd, the PR is marked as being in 202205, I'll recheck tomorrow. |
…net#12959) PR sonic-net#12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Cherry-pick PR to 202205: #13002 |
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
…net#12959) PR sonic-net#12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Cherry-pick PR to 202211: #13045 |
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
added
Included in 202211 Branch
and removed
Request for 202211 Branch
Approved for 202211 Branch
labels
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)