[BRCM-DNX(J2/J2c/J2c+)]:Reserve Non-ECMP Fec Resource for Non-ECMP Route Nexthops/NBR Entries #13076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xthops/NBR Entries
|
|
deepak-singhal0408
added
Request for 202205 Branch
Chassis 🤖
abdosi
changed the title
arlakshm
approved these changes
Dec 16, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 17, 2022
…xthops/NBR Entries (sonic-net#13076) Why I did it On DNX (J2/J2c/J2c+) platforms, Single Path Nexthops and ECMp Nexthop resources(FECs) are shared. BRCM SAI do not have partition of this resource, and hence more single path Nexthop entries, causes ECMP programming to fail in scaled setup. How I did it Broadcom provided SAI changes to reserve resources for single path nexthop entries(More details in CSP: https://brcmsemiconductor-csm.wolkenservicedesk.com/wolken-support/allcases/request-details?requestId=CS00012251649). Along with SAI changes, they provided configurable Macro/flag to reserve NON_ECMP entries. This PR is to add that flag in various sai.profile files wherever applicable. PS: We are reserving 3072 single path Nexthop entries on each Linecard. Calculation is as follows. Max Slots per chassis: 8 Max No of Ports(each LC): 64 MyIP/Subnet Entries per port: 4(v4/v6) Nbr Entries Per port: 2(v4/v6) Total Non_ECMP Count: 8x64x(4+2) = 3072 How to verify it Without this change, the ECMP group count will be shown as Max_count in 'crm show resources all' command, and with this change the ECMP group count will be decreased by 24(3072/128).
|
Cherry-pick PR to 202205: #13089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12608 by reserving NON_ECMP Fec entries for single path Nexthops/V4/v6NBR Entries.
Why I did it
On DNX (J2/J2c/J2c+) platforms, Single Path Nexthops and ECMp Nexthop resources(FECs) are shared. BRCM SAI do not have partition of this resource, and hence more single path Nexthop entries, causes ECMP programming to fail in scaled setup.
How I did it
Broadcom provided SAI changes to reserve resources for single path nexthop entries(More details in CSP: https://brcmsemiconductor-csm.wolkenservicedesk.com/wolken-support/allcases/request-details?requestId=CS00012251649).
Along with SAI changes, they provided configurable Macro/flag to reserve NON_ECMP entries.
This PR is to add that flag in various sai.profile files wherever applicable.
PS: We are reserving 3072 single path Nexthop entries on each Linecard. Calculation is as follows.
Max Slots per chassis: 8
Max No of Ports(each LC): 64
MyIP/Subnet Entries per port: 4(v4/v6)
Nbr Entries Per port: 2(v4/v6)
Total Non_ECMP Count: 8x64x(4+2) = 3072
How to verify it
Without this change, the ECMP group count will be shown as Max_count in 'crm show resources all' command, and with this change the ECMP group count will be decreased by 24(3072/128).
Which release branch to backport (provide reason below if selected)
Since the change is applicable to BRCM DNX pltforms, it needs to go in 202205 branch which is being used for T2-Chassis.
#######UT########
The change has been verified on DNX(J2/j2c/J2c+) platforms..