Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Support Debian snapshot mirror to improve build stability #13097

Merged
merged 4 commits into from
Jan 13, 2023
Merged

[Build] Support Debian snapshot mirror to improve build stability #13097

merged 4 commits into from
Jan 13, 2023

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Dec 18, 2022 •
edited
Loading

Why I did it

[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it

Add a new feature to support the Debian snapshot mirror.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia force-pushed the test-sn branch 3 times, most recently from ed1c24c to 3ed5e8d Compare December 27, 2022 12:53
@xumia xumia changed the title [Build][Test] Support snapshot debian mirror [Build] Support Debian snapshot mirror to improve build stability Dec 27, 2022
@xumia xumia added the Build label Dec 27, 2022
@xumia xumia force-pushed the test-sn branch 2 times, most recently from 06cbced to d85cce3 Compare December 30, 2022 14:16
@xumia xumia marked this pull request as ready for review January 11, 2023 23:57
@xumia xumia merged commit 5e4a866 into sonic-net:master Jan 13, 2023
@xumia xumia deleted the test-sn branch January 13, 2023 08:16
@xumia xumia added Request for 202111 Branch For PRs being requested for 202111 branch Request for 202205 Branch labels Jan 13, 2023
@mssonicbld
Copy link
Collaborator

@xumia PR conflicts with 202205 branch

yxieca pushed a commit that referenced this pull request Feb 10, 2023
@xumia
[Build][202211] Support Debian snapshot mirror to improve build stabi…
c9806ec 
…lity (#13371) (#13382)

Why I did it
Cherry pick from #13097
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
@k-v1
Copy link
Contributor

k-v1 commented Mar 22, 2023

@xumia

You don't export MIRROR_SNAPSHOT in Makefile.work, so you don't pass this flag to build_mirror_config.sh when generate sources.list for sonic-slaves. Is it a correct behaviour?

@xumia
Copy link
Collaborator Author

xumia commented Mar 23, 2023

@xumia

You don't export MIRROR_SNAPSHOT in Makefile.work, so you don't pass this flag to build_mirror_config.sh when generate sources.list for sonic-slaves. Is it a correct behaviour?

@k-v1, I think the variable should be exported. Looks like it will not work if passing the variable in the make variables.

@k-v1
Copy link
Contributor

k-v1 commented Mar 28, 2023 •
edited
Loading

@xumia

One more question about snapshots.
Should we also use them for debootstrap?

sonic-buildimage/scripts/build_debian_base_system.sh

Line 39 in 320366a

sudo http_proxy=$HTTP_PROXY SKIP_BUILD_HOOK=y debootstrap --variant=minbase --arch $CONFIGURED_ARCH $IMAGE_DISTRO $FILESYSTEM_ROOT http://debian-archive.trafficmanager.net/debian

I mean when MIRROR_SNAPSHOT=y but it's not a reproducible build.

@xumia
Copy link
Collaborator Author

xumia commented Mar 29, 2023

http://debian-archive.trafficmanager.net/debian

Good catch, we should use the snapshot one, when the flag set.

@xumia xumia mentioned this pull request Apr 7, 2023
Merged
8 tasks
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 7, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
4546528 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 14, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
2a20559 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
@xumia xumia mentioned this pull request Apr 14, 2023
Merged
10 tasks
@xumia xumia mentioned this pull request Apr 14, 2023
Merged
10 tasks
@xumia xumia mentioned this pull request Apr 14, 2023
Draft
10 tasks
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 14, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
74a2e11 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 17, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
624e48e 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 17, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
0b7ebfa 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 17, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
fa9b3d1 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
xumia added a commit that referenced this pull request Apr 18, 2023
@xumia
[Build][202106] Support Debian snapshot mirror to improve build stabi…
2001bbd 
…lity (#14663)

Why I did it
Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts.

ad162ae [Build] Optimize the version control for Debian packages (#14557)
38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198)
5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913)
8206925 [Build] Change the default mirror version config file (#13786)
5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097)
ac5d89c [Build] Support j2 template for debian sources (#12557)

Work item tracking
Microsoft ADO (number only): 18018114
How I did it
How to verify it
xumia added a commit that referenced this pull request Apr 18, 2023
@xumia
[Build][202111] Support Debian snapshot mirror to improve build stabi…
40780c0 
…lity (#14664)

Why I did it
Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts.

ad162ae [Build] Optimize the version control for Debian packages (#14557)
38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198)
5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913)
8206925 [Build] Change the default mirror version config file (#13786)
5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097)
ac5d89c [Build] Support j2 template for debian sources (#12557)

Work item tracking
Microsoft ADO (number only): 18018114
How I did it
How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 20, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
09bf5b6 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 20, 2023
@xumia
[Build] Support Debian snapshot mirror to improve build stability (so…
2398bf6 
…nic-net#13097)

Why I did it
[Build] Support Debian snapshot mirror to improve build stability

It is to enhance the reproducible build, supports the Debian snapshot mirror. It guarantees all the docker images using the same Debian mirror snapshot and fixes the temporary build failure which is caused by remote Debain mirror indexes changed during the build. It is also to fix the version conflict issue caused by no fixed versions of some of the Debian packages.

How I did it
Add a new feature to support the Debian snapshot mirror.

How to verify it
qiluo-msft pushed a commit that referenced this pull request Apr 21, 2023
@xumia
[Build][202012] Support Debian snapshot mirror to improve build stabi…
ae0a47d 
…lity (#14558)

#### Why I did it
Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts. And add the last commit to fix the build broken issue according to the mirror change.

ad162ae [Build] Optimize the version control for Debian packages (#14557)
38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198)
5e4826e  [Ci] Support to use the same snapshot for all platform builds (#13913)
8206925 [Build] Change the default mirror version config file (#13786)
5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097)
ac5d89c  [Build] Support j2 template for debian sources (#12557)
@k-v1 k-v1 mentioned this pull request Apr 3, 2024
Open
@koutlaws koutlaws mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liushilongbuaa liushilongbuaa liushilongbuaa approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Approved for 202205 Branch Approved for 202211 Branch Build Cherry Pick Conflict_202205 Cherry Pick Conflict_202211 Included in 202205 Branch Request for 202111 Branch For PRs being requested for 202111 branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xumia @mssonicbld @k-v1 @qiluo-msft @liushilongbuaa @yxieca @StormLiangMS