Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MiTAC MiTAC-LY1200-B32H0-C3 platform #1326

Closed
wants to merge 4 commits into from
Closed

Add support for MiTAC MiTAC-LY1200-B32H0-C3 platform #1326

wants to merge 4 commits into from

Conversation

staneshieh
Copy link

- What I did
Add MiTAC-LY1200-B32H0-C3.
- How I did it
Add drv code for sfp, eeprom, psu utility tool
- How to verify it
Test cmd. cat/echo sysfs, spfutil, psu, eeprom, sensors to test.
- Description for the changelog
Add MiTAC-LY1200-B32H0-C3 drv code and utility

- A picture of a cute animal (not mandatory but encouraged)

stane.shieh and others added 3 commits December 28, 2017 16:05
For sonic-linux-kernel and sonic-platform-modules-mitac.

Update and create submodules.
Signed-off-by: Eddy Weng <eddy.weng@mic.com.tw>
Signed-off-by: Eddy Weng <eddy.weng@mic.com.tw>
@msftclas
Copy link

msftclas commented Jan 19, 2018

CLA assistant check
All committers have signed the CLA.

.gitmodules Outdated
@@ -3,7 +3,7 @@
url = https://github.com/Azure/sonic-swss-common
[submodule "sonic-linux-kernel"]
path = src/sonic-linux-kernel
url = https://github.com/Azure/sonic-linux-kernel
url = https://github.com/MiTAC-EBU/sonic-linux-kernel.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably do not want to change this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have restored the contents of .gitmodules to keep Azure sonic linux kernel and opened a new pull request(sonic-net/sonic-linux-kernel#39) for my patches.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep Azure sonic linux kernel, if you have you own patches, then generate PR against the repo.

return BCM_E_NONE;
}

link_monitor(0,1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need such bcm code? what is the purpose?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use one led_proc_init.soc to support different speeds for front panel port physical connections.

The advantage is that as long as SONiC supports port speed changes on Broadcom platform, we don't need to update led_proc_init.soc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understand the requirement, however, we cannot have bcm api call in our repo. for now, we have to remove them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you accept if we moved it to our repo (${sonic}/platform/broadcom/sonic-platform-modules-mitac/)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do this in the right way, if you can propose right SAI API to control the port LED in the SAI community, we can ask the asic vendor to implement it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understand the explanation, we will remove it. I will close this PR and open a new PR when we finish modifications. Thanks a lot.

Signed-off-by: Stane Shieh <stane.shieh@mic.com.tw>
@staneshieh staneshieh closed this Jan 29, 2018
volodymyrsamotiy added a commit to volodymyrsamotiy/sonic-buildimage that referenced this pull request Nov 5, 2020
62e6c5a [bitmap_vnet] Remove BMTOR implementation (sonic-net#1494)
582beae [FPMSYNCD] EVPN Type5 prefix handling in FPMSYNCD (sonic-net#1326)
d9ca6e2 [vstest] Resolve intermittent timing failure in test_fgnhg.py (sonic-net#1495)
a89b8ed [sub intf] Inherit parent port mtu changes (sonic-net#1479)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
lguohan pushed a commit that referenced this pull request Nov 9, 2020
62e6c5a [bitmap_vnet] Remove BMTOR implementation (#1494)
582beae [FPMSYNCD] EVPN Type5 prefix handling in FPMSYNCD (#1326)
d9ca6e2 [vstest] Resolve intermittent timing failure in test_fgnhg.py (#1495)
a89b8ed [sub intf] Inherit parent port mtu changes (#1479)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Jan 20, 2021
* 8119ba2 2021-01-20 | Validations checks while creating and deleting a Portchannel (sonic-net#1326) (HEAD, origin/master, origin/HEAD) [Akhilesh Samineni]
* 3df267e 2021-01-19 | [config] Fix Breakout mode option and BREAKOUT_CFG table check method (sonic-net#1270) [Sangita Maity]
* 9bd709b 2021-01-19 | [show] Fix show arp in case with FDB entries, linked to default VLAN (sonic-net#1357) [maksymbelei95]
* bc2d27e 2021-01-18 | [generate_dump]: fix syntax error [Guohan Lu]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan mentioned this pull request Jan 20, 2021
4 tasks
tahmed-dev added a commit to tahmed-dev/sonic-buildimage that referenced this pull request Jan 20, 2021
Changes in this update:
37695c8 [show]: Use TCP Connection For Muxcable Commands (sonic-net#1371)
8119ba2 Validations checks while creating and deleting a Portchannel (sonic-net#1326)
3df267e [config] Fix Breakout mode option and BREAKOUT_CFG table check method (sonic-net#1270)
9bd709b [show] Fix show arp in case with FDB entries, linked to default VLAN (sonic-net#1357)
bc2d27e [generate_dump]: fix syntax error

signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan pushed a commit that referenced this pull request Jan 21, 2021
Changes in this update:
37695c8 [show]: Use TCP Connection For Muxcable Commands (#1371)
8119ba2 Validations checks while creating and deleting a Portchannel (#1326)
3df267e [config] Fix Breakout mode option and BREAKOUT_CFG table check method (#1270)
9bd709b [show] Fix show arp in case with FDB entries, linked to default VLAN (#1357)
bc2d27e [generate_dump]: fix syntax error

signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan pushed a commit that referenced this pull request Jan 21, 2021
Changes in this update:
37695c8 [show]: Use TCP Connection For Muxcable Commands (#1371)
8119ba2 Validations checks while creating and deleting a Portchannel (#1326)
3df267e [config] Fix Breakout mode option and BREAKOUT_CFG table check method (#1270)
9bd709b [show] Fix show arp in case with FDB entries, linked to default VLAN (#1357)
bc2d27e [generate_dump]: fix syntax error

signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
62e6c5a [bitmap_vnet] Remove BMTOR implementation (sonic-net#1494)
582beae [FPMSYNCD] EVPN Type5 prefix handling in FPMSYNCD (sonic-net#1326)
d9ca6e2 [vstest] Resolve intermittent timing failure in test_fgnhg.py (sonic-net#1495)
a89b8ed [sub intf] Inherit parent port mtu changes (sonic-net#1479)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
…et#1326)

Added below validation checks when a portchannel is created by the user:
1 if a given portchannel name is valid or not
2 if a given portchannel name is already created by user (exists in CONFIG_DB)

Added below validation checks when a portchannel is attempted for deletion by the user:
1 if a given portchannel name is valid or not
2 if a given portchannel name exists in exists in CONFIG_DB or not (throw an error if it does not exist)

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
EVPN Type5 prefix handling in FPMSYNCD.
Add raw netlink msg processing for EVPN routes since rt_nl doesn't provide support to extract custom msg from the netlink msg.
mssonicbld added a commit that referenced this pull request Nov 29, 2023
…tically (#17334)

#### Why I did it
src/sonic-sairedis
```
* 9621316 - (HEAD -> master, origin/master, origin/HEAD) [syncd] Remove notify pointers manual handling (#1326) (19 hours ago) [Kamil Cudnik]
```
#### How I did it
#### How to verify it
#### Description for the changelog
yxieca pushed a commit that referenced this pull request Dec 13, 2023
…tically (#17454)

src/sonic-sairedis

* 9621316 - (HEAD -> 202311, origin/202311) [syncd] Remove notify pointers manual handling (#1326) (2 weeks ago) [Kamil Cudnik]
* 4ee9c25 - Add TestSwitch missing attribute (#1327) (2 weeks ago) [noaOrMlnx]
* 4cbbeed - Add SAI Notification support for host_tx_ready (#1307) (2 weeks ago) [noaOrMlnx]
* 9804bd7 - Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined (#1324) (3 weeks ago) [Ashish Singh]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants