Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamd: Add support for custom retry counts for LACP sessions #13453

Merged
merged 14 commits into from
Jun 9, 2023
Merged

teamd: Add support for custom retry counts for LACP sessions #13453

merged 14 commits into from
Jun 9, 2023

Commits on Jan 20, 2023

  1. teamd: Add support for custom retry counts for LACP sessions 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    aa248b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Add _SECONDS to #define name to make it clear this is in seconds 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b9daabb View commit details
    Browse the repository at this point in the history

  2. Fix mix of spaces vs tabs 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ba9325c View commit details
    Browse the repository at this point in the history

  3. Rename patches to include patch order number 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    4d7730f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Use monotonic time instead of wall-clock time 

    Also fix a bug with `next_retry_count_change_time` getting calculated
repeatedly when a non-standard retry count is sent.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    304a444 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Replace magic number of 3 with existing define 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    ec258ed View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge remote-tracking branch 'origin/master' into teamd-retry-count

    @saiarcot895
    saiarcot895 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6035645 View commit details
    Browse the repository at this point in the history

  2. Add support for showing the partner's retry count 

    Also fix a logic error when filling in the retry count fields in the
LACP PDU packet.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    27cdefb View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Make changes to the transition mechanism 

    First, reply with the most recently received LACP PDU version. This is
so that if one side is sending both the old and new versions, then the
peer side will send both versions to keep both listeners happy. This
also allows for using the new version packets even when the retry count
is 3 on both sides. This can only be triggered remotely; there's no
local command to force a particular version to be used.

Second, reset the 60-second timer preventing the retry count from being
reset back to 3 every time a new version PDU is received. This keeps
that setting persistent for longer with the downside of a delayed
response to the retry count being reset to 3.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    51b1191 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Send LACPDU immediately on version change 

    After getting a LACPDU that uses a diferent LACPDU version, immediately
send a LACPDU back.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    e977386 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Add option to disable retry count feature, and fix some bugs 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    357cd54 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Use LACP_CFG_DFLT_RETRY_COUNT if an invalid retry count is set via co… 

    …nfig

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f80bbfd View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge remote-tracking branch 'origin/master' into teamd-retry-count

    @saiarcot895
    saiarcot895 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e07744b View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Address review comments 

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    @saiarcot895
    saiarcot895 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    67c1d52 View commit details
    Browse the repository at this point in the history