Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc platform improvements for DCS-7060DX5-64S #13875

Merged

Conversation

aaronpayment
Copy link
Contributor

Why I did it

Misc platform improvements for DCS-7060DX5-64S.

Includes changes for:

  • Add 7060DX5-64S brcm tunnel config support
  • Set port config ENABLE:0 in 7060DX5-64S brcm config
  • Sensor.conf fixes
  • SFP port support
  • Add copper 50g tuning to babbagelp

How I did it

Commits describe the changes

How to verify it

Fixes have been uncovered and validated in our in house testing and running sonic-mgmt testing on DCS-7060DX5-64S.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Misc platform improvements for DCS-7060DX5-64S.

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

aaronpayment and others added 5 commits February 17, 2023 15:10
Add bcm_tunnel_term_compatible_mode: 1 support, which allows
Loopback configuration to no longer result in SAI failure
"tunnel terminator add failed with error Feature unavailable"
that caused Orchagent SIGABRT

Signed-off-by: Aaron Payment <aaronp@arista.com>
Set ENABLE:0 for the front panel ports in the brcm config so that the
ports are default admin down. This change prevents the issue that ports
are able to link up and pass traffic resulting in mac learn events after
SAI create switch and before SAI admin state up. The unexpected mac learn events
resulted in Orch agent crash in PortsOrch init, which occurs after SAI
create switch and before SAI admin state up.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@aaronpayment aaronpayment changed the title Master platform catalina dd fix tunnel Misc platform improvements for DCS-7060DX5-64S Feb 22, 2023
@StormLiangMS
Copy link
Contributor

@prgeor could you help to review?

Copy link
Contributor

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yxieca can you merge

@yxieca
Copy link
Contributor

yxieca commented Aug 18, 2023

/Semgrep

@yxieca
Copy link
Contributor

yxieca commented Aug 18, 2023

/azp run Semgrep

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@yxieca yxieca merged commit a4098de into sonic-net:master Aug 18, 2023
1 check passed
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
* sonic-buildimage: Add 7060DX5-64S brcm tunnel config

Add bcm_tunnel_term_compatible_mode: 1 support, which allows
Loopback configuration to no longer result in SAI failure
"tunnel terminator add failed with error Feature unavailable"
that caused Orchagent SIGABRT

Signed-off-by: Aaron Payment <aaronp@arista.com>

* sonic-buildimage: Set port config ENABLE:0 in 7060DX5-64S brcm config

Set ENABLE:0 for the front panel ports in the brcm config so that the
ports are default admin down. This change prevents the issue that ports
are able to link up and pass traffic resulting in mac learn events after
SAI create switch and before SAI admin state up. The unexpected mac learn events
resulted in Orch agent crash in PortsOrch init, which occurs after SAI
create switch and before SAI admin state up.

* fix sensors.conf on CatalinaDD

* Add support for two sfp ports

* Add copper 50g tuning to babbagelp on catalina

---------

Signed-off-by: Aaron Payment <aaronp@arista.com>
Co-authored-by: enes.oncu <enes.oncu@arista.com>
Co-authored-by: Boyang Yu <byu@arista.com>
@aaronpayment aaronpayment deleted the master-platform-catalina-dd-fix-tunnel- branch November 28, 2023 23:29
StormLiangMS pushed a commit that referenced this pull request Apr 30, 2024
Why I did it
Misc platform improvements for DCS-7060DX5-64S.

NOTE: these changes have been committed to master and 202311 branches via PR #13875. Objective of this PR is to bring equivalent changes to 202305 branch.

Includes changes for:

Add 7060DX5-64S brcm tunnel config support
Set port config ENABLE:0 in 7060DX5-64S brcm config
Sensor.conf fixes
SFP port support
Add copper 50g tuning to babbagelp
How I did it
Commits describe the changes

How to verify it
Fixes have been uncovered and validated in our in-house testing and running sonic-mgmt testing on DCS-7060DX5-64S. For this backport request, the fixes are retested on 202305 via in-house testing.
lguohan pushed a commit that referenced this pull request May 12, 2024
Follow-up to "Misc platform improvements for DCS-7060DX5-64S" filed originally as PR #13875.

While generating a 202305 backport of the aforementioned PR, some fixes were identified and implemented to the sensors.conf file on 202305. These same changes are being upstreamed as part of this PR to master and 202311 to bring the branches into alignment.

The 202305 backport is tracked under PR #18701.

How I did it
Sensor modifications corresponding to the platform implementation.

How to verify it
Fixes have been validated in our in-house testing and running sonic-mgmt testing on DCS-7060DX5-64S.

Co-authored-by: enes.oncu <enes.oncu@arista.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 12, 2024
Follow-up to "Misc platform improvements for DCS-7060DX5-64S" filed originally as PR sonic-net#13875.

While generating a 202305 backport of the aforementioned PR, some fixes were identified and implemented to the sensors.conf file on 202305. These same changes are being upstreamed as part of this PR to master and 202311 to bring the branches into alignment.

The 202305 backport is tracked under PR sonic-net#18701.

How I did it
Sensor modifications corresponding to the platform implementation.

How to verify it
Fixes have been validated in our in-house testing and running sonic-mgmt testing on DCS-7060DX5-64S.

Co-authored-by: enes.oncu <enes.oncu@arista.com>
mssonicbld pushed a commit that referenced this pull request Sep 12, 2024
Follow-up to "Misc platform improvements for DCS-7060DX5-64S" filed originally as PR #13875.

While generating a 202305 backport of the aforementioned PR, some fixes were identified and implemented to the sensors.conf file on 202305. These same changes are being upstreamed as part of this PR to master and 202311 to bring the branches into alignment.

The 202305 backport is tracked under PR #18701.

How I did it
Sensor modifications corresponding to the platform implementation.

How to verify it
Fixes have been validated in our in-house testing and running sonic-mgmt testing on DCS-7060DX5-64S.

Co-authored-by: enes.oncu <enes.oncu@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants