[action] [PR:12963] [build] Fix unexpected warnings: No names found, cannot describe anything. #13927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing. (sonic-net#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
mssonicbld
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
8 tasks
|
Original PR: #12963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.