Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action] [PR:12963] [build] Fix unexpected warnings: No names found, cannot describe anything. #13928

Merged
merged 1 commit into from
Mar 10, 2023
Merged

[action] [PR:12963] [build] Fix unexpected warnings: No names found, cannot describe anything. #13928

merged 1 commit into from
Mar 10, 2023

Commits on Feb 22, 2023

  1. [build] Fix unexpected warnings: No names found, cannot describe anyt… 

    …hing. (sonic-net#12963)

Why I did it
In PR check pipelines, there are too many duplicated warnings:
fatal: No names found, cannot describe anything.
SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it.
In Makefile, '=' will calculate again and again when it is referred.

How I did it
Fix it in Makefile.

How to verify it
Check this PR's check pipeline result.
    @liushilongbuaa @mssonicbld
    liushilongbuaa authored and mssonicbld committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    64a1bc7 View commit details
    Browse the repository at this point in the history