-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dhcpv6-relay yang model #14144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see rfc6939_support. Please add that as well. You need to add UT, update sample_config_db.json and update configuration guide. Please check this PR for example #13735
rfc6939_support is already included.
Will add UT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also need update test cases for this yang module.
Test cases under:
sonic-yang-models/tests/yang_model_tests/tests/
Just found there is already comments about this :-) |
@kellyyeh can you please help to fix the conflict? Thanks. |
@kellyyeh Can you please resolve the conflicts and push again? |
@kellyyeh please handle conflicts. |
@kellyyeh I believe the conflict still exists. Can you please check? |
a1e801d
to
1be6c2e
Compare
Thanks, should be resolved now |
Seems like it cannot be cherry-picked cleanly, I will create cherry-pick PRs after this is merged |
@yxieca @kellyyeh @qiluo-msft Can you please help merge this? |
Why I did it Add interface-id in dhcpv6-relay yang model How I did it Add interface-id option and corresponding UT. Updated configuration.md How to verify it kellyyeh@kellyyeh:~/sonic-buildimage/src/sonic-yang-models$ pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-dhcpv6-relay.yang
Cherry-pick PR to 202205: #14245 |
Why I did it Add interface-id in dhcpv6-relay yang model How I did it Add interface-id option and corresponding UT. Updated configuration.md How to verify it kellyyeh@kellyyeh:~/sonic-buildimage/src/sonic-yang-models$ pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-dhcpv6-relay.yang
Cherry-pick PR to 202211: #14329 |
Why I did it Add interface-id in dhcpv6-relay yang model How I did it Add interface-id option and corresponding UT. Updated configuration.md How to verify it kellyyeh@kellyyeh:~/sonic-buildimage/src/sonic-yang-models$ pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-dhcpv6-relay.yang
Why I did it
Add interface-id in dhcpv6-relay yang model
How I did it
Add interface-id option and corresponding UT. Updated configuration.md
How to verify it
kellyyeh@kellyyeh:~/sonic-buildimage/src/sonic-yang-models$ pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-dhcpv6-relay.yang
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)