Add SECURE_UPGRADE_PROD_TOOL_ARGS flag to make it possible for vendor… #14581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to pass their own arguments on the prod signing script
|
@davidpil2002 please review this one pls |
davidpil2002
previously approved these changes
Apr 13, 2023
qiluo-msft
reviewed
Apr 18, 2023
| @@ -674,8 +674,12 @@ if [[ $SECURE_UPGRADE_MODE == 'dev' || $SECURE_UPGRADE_MODE == "prod" && $SONIC_ | |||
| exit 1 | |||
| fi | |||
|
|
|||
| sudo $SECURE_UPGRADE_PROD_SIGNING_TOOL $CONFIGURED_ARCH $FILESYSTEM_ROOT $LINUX_KERNEL_VERSION $OUTPUT_SEC_BOOT_DIR | |||
|
|
|||
| sudo $sonic_su_prod_signing_tool -a $CONFIGURED_ARCH \ | |||
There was a problem hiding this comment.
Yes, it will support for all the vendors.
It aligns the prod secure scripts flags with the dev secure script flags.
DavidZagury
force-pushed
the
prod_sign_extra_prod_args
branch
from
0963c83
to
a52492e
Compare
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 1, 2023
|
@qiluo-msft could you please help to approve/merge? |
qiluo-msft
approved these changes
May 16, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 16, 2023
…s to pass their own arguments on the prod signing script (sonic-net#14581) - Why I did it Since the prod signing tool is vendor specific, and each vendor may have different arguments they would like to use in the script, we would need a way to inject those arguments to the script. - How I did it Add a compilation flag SECURE_UPGRADE_PROD_TOOL_ARGS which vendors can use to inject any flag they would want to the prod signing script. - How to verify it Build SONiC using your own prod script
|
Cherry-pick PR to 202211: #15095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to pass their own arguments on the prod signing script
Why I did it
Since the prod signing tool is vendor specific, and each vendor may have different arguments they would like to use in the script, we would need a way to inject those arguments to the script.
How I did it
Add a compilation flag SECURE_UPGRADE_PROD_TOOL_ARGS which vendors can use to inject any flag they would want to the prod signing script.
How to verify it
Build SONiC using your own prod script
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)