Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file for mgmt interface #1544

wendani · 2018-03-29T05:30:17Z

In generating the interfaces file, put ipv4 config ahead of ipv6 for the mgmt interface

This solves the problem that the mgmt interface does not get its ipv4 address

Signed-off-by: Wenda wenni@microsoft.com

- What I did
Put ipv4 config ahead of ipv6 for the mgmt interface. I observe that on one DUT, the mgmt interface does not possess its IPv4 address and fails to be brought up if the other way round.

- How I did it
Change interfaces.j2

- How to verify it
reboot and see if the mgmt interface has IPv4 address and is reachable.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

mgmt interface This solves the problem that the mgmt interface does not get its ipv4 address Signed-off-by: Wenda <wenni@microsoft.com>

yxieca

Please file an issue to track the symptom. We need to revisit the problem in the future in case it hides something bigger.

lguohan · 2018-03-29T16:49:38Z

files/image_config/interfaces/interfaces.j2

@@ -21,7 +21,7 @@ iface lo {{ 'inet' if prefix | ipv4 else 'inet6' }} static
 # The management network interface
 auto eth0
 {% if MGMT_INTERFACE %}
-{% for (name, prefix) in MGMT_INTERFACE %}
+{% for (name, prefix) in MGMT_INTERFACE|sort %}


why sort put v4 ahead of v6? is that a co-incidence?

The name field is the same, eth0, for both v4 and v6. The sort is based on what is taken in the prefix

there is no guarantee that v4 prefix will be ahead of v6 prefix.

stcheng · 2018-03-29T20:57:16Z

there're tests in the sonic-cfggen could you also update the tests there?

stcheng

please update the src/sonic-config-engine/tests/sample_output

lguohan

the sort result is un-deterministic.

Signed-off-by: Wenda <wenni@microsoft.com>

lguohan · 2018-04-02T04:47:42Z

src/sonic-config-engine/sonic-cfggen

@@ -33,6 +33,11 @@ from swsssdk import ConfigDBConnector
 from collections import OrderedDict
 from natsort import natsorted

+def sift_up_ipv4(value):


sort_by_prefix

add comments:
for interface name is the same, then sort by prefix. v4 address is before v6 address

lguohan · 2018-04-02T04:48:13Z

Need unit test on interfaces.j2 file.

Signed-off-by: Wenda <wenni@microsoft.com>

wendani · 2018-04-02T19:06:22Z

@stcheng src/sonic-config-engine/tests/sample_output has the correct order---v4 profile ahead of v6

Modify the ipv6 address such that without sort_by_prefix filter the data taken in will have ipv6 profile before ipv4 in the generated interfaces config file Signed-off-by: Wenda <wenni@microsoft.com>

wendani · 2018-04-03T01:27:35Z

src/sonic-config-engine/tests/t0-sample-graph.xml

          </a:Prefix>
-          <a:PrefixStr>2603:10e2:0:2902::8/64</a:PrefixStr>
+          <a:PrefixStr>603:10e2:0:2902::8/64</a:PrefixStr>


Change the ipv6 address such that without the sort_by_prefix filter, the interfaces.j2 template will place ipv6 profile ahead of ipv4:

--- sample_output/interfaces 2018-04-02 21:28:10.122688400 +0000
+++ /home/localadmin/interfaces 2018-04-02 23:36:40.086688400 +0000
@@ -17,6 +17,18 @@
#
# The management network interface
auto eth0
+iface eth0 inet6 static
+ address 603:10e2:0:2902::8
+ netmask 64
+ ########## management network policy routing rules
+ # management port up rules
+ up ip -6 route add default via 603:10e2:0:2902::1 dev eth0 table default
+ up ip -6 route add 603:10e2:0:2902::/64 dev eth0 table default
+ up ip -6 rule add from 603:10e2:0:2902::8/128 table default
+ # management port down rules
+ down ip -6 route delete default via 603:10e2:0:2902::1 dev eth0 table default
+ down ip -6 route delete 603:10e2:0:2902::/64 dev eth0 table default
+ down ip -6 rule delete from 603:10e2:0:2902::8/128 table default
iface eth0 inet static
address 10.0.0.100
netmask 255.255.255.0
@@ -31,18 +43,6 @@
down ip -4 route delete 10.0.0.0/24 dev eth0 table default
down ip -4 rule delete from 10.0.0.100/32 table default
down ip rule delete to 10.20.6.16/32 table default
-iface eth0 inet6 static
- address 2603:10e2:0:2902::8
- netmask 64
- ########## management network policy routing rules
- # management port up rules
- up ip -6 route add default via 2603:10e2:0:2902::1 dev eth0 table default
- up ip -6 route add 2603:10e2:0:2902::/64 dev eth0 table default
- up ip -6 rule add from 2603:10e2:0:2902::8/128 table default
- # management port down rules
- down ip -6 route delete default via 2603:10e2:0:2902::1 dev eth0 table default
- down ip -6 route delete 2603:10e2:0:2902::/64 dev eth0 table default
- down ip -6 rule delete from 2603:10e2:0:2902::8/128 table default
#
# The switch front panel interfaces
# "|| true" is added to suppress the error when interface is already a member of LAG

lguohan · 2018-05-12T08:32:05Z

root caused in #1701. drop this PR.

ad9022ebf9c13b59ef8dc47aaa1f89628e64315e (HEAD -> 201911, origin/201911) Reduce time taken by show commands on multi-asic platforms (#1544) 4993a3644bff689701aac2ee2b10c351a9d241ef [fast-reboot]: Fix fail to execute fast-reboot problem (#1047) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

27ad705 Update PR 1310 with change of the function _checkNoPortsInAsicDb to checkNoPortsInAsicDb 55c64f2 [config/main.py]: Filter table from input config while config validation\DPB. 1993087 [config_mgmt.py]: Verify port status down in APPL DB. 69a5077 Replace call with mock.call cf52272 interface_name_is_valid add arg config_db 0834863 [config/main.py]: Use click.abort() and fix test case by deepcopy(). 7c76602 Fix _shutdownIntf to check correct call bbf05e1 [tests/config_mgmt_test.py]: Minor changes to fix tests. 5e69412 Tests for shutdown intf 2352650 [config_mgmt.py]: Shutdown the interfaces after config validation. (sonic-net#28) 9bbc25f [config] Eliminate race condition between reloading Monit config and (sonic-net#1543) 87b2481 Reduce time taken by show commands on multi-asic platforms (sonic-net#1544) 12fc01e [reboot] No need enable the Linux magic system request key (sonic-net#1538) e0f678a [setup.py]: move the module to test requirement (sonic-net#1542) d55d406 [acl_loader]: add iptype match to the rules for dataplane acl 37376dd [ci]: download latest docker-sonic-vs from sonic-swss repo e9cfb32 [fast-reboot] Fix dump script to support PortChannels in a VLAN group (sonic-net#1393) Signed-off-by: allas <allas@nvidia.com>

SWSS: * d97c7c7 2021-04-07 | [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693) (HEAD -> 202012) [Stephen Sun] * f70b3da 2021-04-03 | [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689) [Kamil Cudnik] * 72ae85d 2021-04-08 | [vlan] Add support of VLAN host interface (sonic-net#1645) [Volodymyr Samotiy] * a555b9c 2021-04-02 | Correct the sflow default sample rate (sonic-net#1623) [fredyu190011] Utilities: * 1a789d2 2021-04-07 | Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551) (HEAD -> 202012) [Renuka Manavalan] * 2412e3c 2021-04-06 | Fix fast-reboot-dump.py SonicV2Connector after late merge (sonic-net#1546) [shlomibitton] * f99c5f1 2021-04-02 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group (sonic-net#1393) [shlomibitton] * 716e2af 2021-04-04 | Reduce time taken by show commands on multi-asic platforms (sonic-net#1544) [abdosi] * a160519 2021-04-03 | [setup.py]: move the module to test requirement (sonic-net#1542) [lguohan] * eaa67fe 2021-04-04 | [config] Eliminate race condition between reloading Monit config and (sonic-net#1543) [yozhao101] * 2497a9e 2021-04-03 | [reboot] No need enable the Linux magic system request key (sonic-net#1538) [yozhao101] * 9fda6fe 2021-04-06 | [fwutil]: Fix next image mount (sonic-net#1533) [Nazarii Hnydyn] * 9af50fe 2021-02-09 | Import 'mock' module from 'unittest' library (sonic-net#1415) (HEAD -> 202012) [Joe LeVeque] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

SWSS: * d97c7c7 2021-04-07 | [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (#1693) (HEAD -> 202012) [Stephen Sun] * f70b3da 2021-04-03 | [Makefile] Reorder libsaimetadata and libswsscommon (#1689) [Kamil Cudnik] * 72ae85d 2021-04-08 | [vlan] Add support of VLAN host interface (#1645) [Volodymyr Samotiy] * a555b9c 2021-04-02 | Correct the sflow default sample rate (#1623) [fredyu190011] Utilities: * 1a789d2 2021-04-07 | Fixed the possibility of using uninitialized variable in route_check.py (#1551) (HEAD -> 202012) [Renuka Manavalan] * 2412e3c 2021-04-06 | Fix fast-reboot-dump.py SonicV2Connector after late merge (#1546) [shlomibitton] * f99c5f1 2021-04-02 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group (#1393) [shlomibitton] * 716e2af 2021-04-04 | Reduce time taken by show commands on multi-asic platforms (#1544) [abdosi] * a160519 2021-04-03 | [setup.py]: move the module to test requirement (#1542) [lguohan] * eaa67fe 2021-04-04 | [config] Eliminate race condition between reloading Monit config and (#1543) [yozhao101] * 2497a9e 2021-04-03 | [reboot] No need enable the Linux magic system request key (#1538) [yozhao101] * 9fda6fe 2021-04-06 | [fwutil]: Fix next image mount (#1533) [Nazarii Hnydyn] * 9af50fe 2021-02-09 | Import 'mock' module from 'unittest' library (#1415) (HEAD -> 202012) [Joe LeVeque] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…#1544) Optimize/Reduce the time taken by show interface * and show ip bgp * commands on Multi-asic platforms.

In generating the interfaces file, put ipv4 config ahead of ipv6 for the

32c2c9d

mgmt interface This solves the problem that the mgmt interface does not get its ipv4 address Signed-off-by: Wenda <wenni@microsoft.com>

wendani requested review from lguohan and yxieca March 29, 2018 05:30

yxieca approved these changes Mar 29, 2018

View reviewed changes

lguohan reviewed Mar 29, 2018

View reviewed changes

wendani mentioned this pull request Mar 29, 2018

DUT mgmt interface does not get v4 IP address #1548

Closed

Merge remote-tracking branch 'public/master' into intrfaces

0b44ae9

stcheng suggested changes Mar 29, 2018

View reviewed changes

stcheng added the Bug 🐛 label Mar 29, 2018

lguohan requested changes Mar 30, 2018

View reviewed changes

wendani added 4 commits April 2, 2018 01:12

For each interface, sift up its ipv4 config profile to the top

528ebbc

Signed-off-by: Wenda <wenni@microsoft.com>

Merge branch 'publicmaster' into intrfaces

f934a97

Improve codes

a027d7c

Signed-off-by: Wenda <wenni@microsoft.com>

Sort with interface name as the primary key and sift up ipv4 address

4b8126d

Signed-off-by: Wenda <wenni@microsoft.com>

lguohan reviewed Apr 2, 2018

View reviewed changes

Change function name and add comment as requested

fb52836

Signed-off-by: Wenda <wenni@microsoft.com>

wendani added 2 commits April 2, 2018 21:27

Merge remote-tracking branch 'public/master' into intrfaces

45dad1a

Update unit test on interfaces.j2 template:

bb898ae

Modify the ipv6 address such that without sort_by_prefix filter the data taken in will have ipv6 profile before ipv4 in the generated interfaces config file Signed-off-by: Wenda <wenni@microsoft.com>

wendani changed the title ~~/etc/network/interfaces file~~ Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file Apr 3, 2018

wendani changed the title ~~Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file~~ Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file for mgmt interface Apr 3, 2018

lguohan approved these changes Apr 3, 2018

View reviewed changes

wendani commented Apr 3, 2018

View reviewed changes

stcheng approved these changes Apr 5, 2018

View reviewed changes

wendani added 4 commits April 10, 2018 02:24

Merge remote-tracking branch 'public/master' into intrfaces

e78a8d2

Merge remote-tracking branch 'public/master' into intrfaces

569f703

Merge remote-tracking branch 'public/master' into intrfaces

eec9686

Merge remote-tracking branch 'public/master' into intrfaces

3e177aa

lguohan closed this May 12, 2018

wendani deleted the intrfaces branch May 18, 2018 19:36

yxieca mentioned this pull request Apr 8, 2021

[202012][swss][utilities] advance submodule heads #7267

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file for mgmt interface #1544

Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file for mgmt interface #1544

wendani commented Mar 29, 2018 •

edited

Loading

yxieca left a comment

lguohan Mar 29, 2018

wendani Mar 29, 2018

lguohan Mar 30, 2018

stcheng commented Mar 29, 2018

stcheng left a comment

lguohan left a comment

lguohan Apr 2, 2018

lguohan commented Apr 2, 2018

wendani commented Apr 2, 2018 •

edited

Loading

wendani Apr 3, 2018

lguohan commented May 12, 2018

Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file for mgmt interface #1544

Ensuring ipv4 config ahead of ipv6 in /etc/network/interfaces file for mgmt interface #1544

Conversation

wendani commented Mar 29, 2018 • edited Loading

yxieca left a comment

Choose a reason for hiding this comment

lguohan Mar 29, 2018

Choose a reason for hiding this comment

wendani Mar 29, 2018

Choose a reason for hiding this comment

lguohan Mar 30, 2018

Choose a reason for hiding this comment

stcheng commented Mar 29, 2018

stcheng left a comment

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

lguohan Apr 2, 2018

Choose a reason for hiding this comment

lguohan commented Apr 2, 2018

wendani commented Apr 2, 2018 • edited Loading

wendani Apr 3, 2018

Choose a reason for hiding this comment

lguohan commented May 12, 2018

wendani commented Mar 29, 2018 •

edited

Loading

wendani commented Apr 2, 2018 •

edited

Loading