-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable info log for graceful restart events #15535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The only concern is whether any of these log will get triggered over and over again?
What I am asking is if whether these events is in some kind of a timer based loop where it will just keep printing? if not, then I think it is a good change.
@gechiang this log added for timer start and stop, which is to trace the GR procedure, it won't be always on for the timer. |
Why I did it Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered. Work item tracking Microsoft ADO (13875291): How I did it To create patch file to change from debug level to info level. How to verify it To run PR test and capture the print.
Cherry-pick PR to 202305: #15601 |
@StormLiangMS PR conflicts with 202205 branch |
@StormLiangMS PR conflicts with 202211 branch |
#### Why I did it cherry pick, #15535 Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered. ##### Work item tracking - Microsoft ADO **(13875291)**: #### How I did it To create patch file to change from debug level to info level. #### How to verify it To run PR test and capture the print.
#15863 cherry-pick PR to 202205 |
Why I did it Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered. Work item tracking Microsoft ADO (13875291): How I did it To create patch file to change from debug level to info level. How to verify it To run PR test and capture the print.
Why I did it
Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered.
Work item tracking
How I did it
To create patch file to change from debug level to info level.
How to verify it
To run PR test and capture the print.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)