Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable info log for graceful restart events #15535

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

StormLiangMS
Copy link
Contributor

@StormLiangMS StormLiangMS commented Jun 19, 2023

Why I did it

Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered.

Work item tracking
  • Microsoft ADO (13875291):

How I did it

To create patch file to change from debug level to info level.

How to verify it

To run PR test and capture the print.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link
Collaborator

@gechiang gechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The only concern is whether any of these log will get triggered over and over again?
What I am asking is if whether these events is in some kind of a timer based loop where it will just keep printing? if not, then I think it is a good change.

@StormLiangMS
Copy link
Contributor Author

Looks good to me. The only concern is whether any of these log will get triggered over and over again? What I am asking is if whether these events is in some kind of a timer based loop where it will just keep printing? if not, then I think it is a good change.

@gechiang this log added for timer start and stop, which is to trace the GR procedure, it won't be always on for the timer.

@StormLiangMS StormLiangMS merged commit a67bffa into sonic-net:master Jun 21, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 23, 2023
Why I did it
Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered.

Work item tracking
Microsoft ADO (13875291):
How I did it
To create patch file to change from debug level to info level.

How to verify it
To run PR test and capture the print.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #15601

@mssonicbld
Copy link
Collaborator

@StormLiangMS PR conflicts with 202205 branch

@mssonicbld
Copy link
Collaborator

@StormLiangMS PR conflicts with 202211 branch

qiluo-msft pushed a commit that referenced this pull request Jul 14, 2023
#### Why I did it
cherry pick, #15535

Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered.

##### Work item tracking
- Microsoft ADO **(13875291)**:

#### How I did it
To create patch file to change from debug level to info level. 

#### How to verify it
To run PR test and capture the print.
@StormLiangMS
Copy link
Contributor Author

#15863 cherry-pick PR to 202205

sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Why I did it
Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered.

Work item tracking
Microsoft ADO (13875291):
How I did it
To create patch file to change from debug level to info level.

How to verify it
To run PR test and capture the print.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants