Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NPU SKU for docker-sonic-vs #15604

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

prabhataravind
Copy link
Contributor

@prabhataravind prabhataravind commented Jun 23, 2023

  • Define a generic 2-port NPU SKU for docker-sonic-vs

Why I did it

To enable DASH vstests to pass on azure pipelines

Work item tracking
  • Microsoft ADO 24375371:

How I did it

Define a generic 2-port NPU hwsku that is used only for DASH-specific vstests.

How to verify it

By making sure that DASH vstests are able to run and pass on azure pipeline.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Currently, DASH specific vstests are being run against BF3 hwsku (Nvidia-MBF2H536C) which is only available in nvdia-sonic sonic-buildimage repo. To let these DASH specific tests pass, a generic 2-port "NPU-2P" hwsku is being defined instead in sonic-net sonic-buildimage repo.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

 * Define a generic NPU SKU for docker-sonic-vs

Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
@prsunny
Copy link
Contributor

prsunny commented Jun 23, 2023

Please fix description

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 15604 in repo sonic-net/sonic-buildimage

@prabhataravind
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

 * Change HWKSU to "NPU-2P" from "NPU" to reflect 2 ports

Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
@prabhataravind prabhataravind marked this pull request as ready for review June 26, 2023 23:06
@lguohan lguohan merged commit d4de62d into sonic-net:master Jun 27, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Define a generic 2-port NPU SKU for docker-sonic-vs to 
enable DASH vstests to pass on azure pipelines

Work item tracking
Microsoft ADO 24375371:

How I did it
Define a generic 2-port NPU hwsku that is used only for DASH-specific vstests.

Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants