Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minigraph parser] Fix minigraph parser issue when handling ACL table #1601

Closed
wants to merge 1 commit into from
Closed

[minigraph parser] Fix minigraph parser issue when handling ACL table #1601

wants to merge 1 commit into from

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Apr 16, 2018

- What I did
Fix minigraph parser issue when handling LAG related case for ACL table:

  1. Previously when attach ACL to a LAG port, it will break the LAG into member ports and then add all these member ports to the ACL table.
  2. When handling 'erspan' table, it just add all the front panel interfaces to the ACL table, but in some topo like T1-LAG, some front panel interfaces already added to LAG port, attach ACL to these front panel ports will fail.

- How I did it

  1. Stop breaking LAG port into member ports when in the case to attach ACL to LAG port.
  2. When handling 'erspan' table, if front panel port already been added to LAG, add the LAG instead of the front panel port.

- How to verify it

run ACL and Everflow test cases on different topo.

- Description for the changelog

modified: src/sonic-config-engine/minigraph.py

- A picture of a cute animal (not mandatory but encouraged)

@keboliu
Fix minigraph parser issue when handling LAG related case for ACL ta…
864f080 
…ble:

   1. previously when attach ACL to a LAG port, it will break the LAG into member ports and then add all these member ports to the ACL table.
   2. When handling 'erspan' table, it just add all the front panel interfaces to the ACL table, shall consider LAG case.

  Changes to be committed:
	modified:   src/sonic-config-engine/minigraph.py

   signed-off-by kebol@mellanox.com
@keboliu keboliu closed this Apr 16, 2018
@keboliu keboliu deleted the minigraph-parser branch April 17, 2018 03:51
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Jan 25, 2021
@lguohan
[submodule]: update sonic-swss
206b010 
* f4e8245 2021-01-24 | [fpmsyncd] Skip routes to eth0 or docker0 (sonic-net#1606) (HEAD, origin/master, origin/HEAD) [Shi Su]
* f4c3579 2021-01-23 | Enhance dynamic buffer calculation and bug fixes (sonic-net#1601) [Stephen Sun]
* e800c9f 2021-01-22 | [logfile]: Add option to specify swss rec file name (sonic-net#1546) [arlakshm]
* 1acf60e 2021-01-17 | Implementation of System ports initialization, Interface & Neighbor Synchronization... (sonic-net#1431) [minionatwork]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit that referenced this pull request Jan 25, 2021
@lguohan
[submodule]: update sonic-swss
a38377e 
* f4e8245 2021-01-24 | [fpmsyncd] Skip routes to eth0 or docker0 (#1606) (HEAD, origin/master, origin/HEAD) [Shi Su]
* f4c3579 2021-01-23 | Enhance dynamic buffer calculation and bug fixes (#1601) [Stephen Sun]
* e800c9f 2021-01-22 | [logfile]: Add option to specify swss rec file name (#1546) [arlakshm]
* 1acf60e 2021-01-17 | Implementation of System ports initialization, Interface & Neighbor Synchronization... (#1431) [minionatwork]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit that referenced this pull request Jan 25, 2021
@lguohan
[submodule]: update sonic-swss
e6c98ea 
* 01c3abd 2021-01-23 | Enhance dynamic buffer calculation and bug fixes (#1601) (HEAD, origin/202012) [Stephen Sun]
* e7af660 2021-01-24 | [fpmsyncd] Skip routes to eth0 or docker0 (#1606) [Shi Su]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@alexrallen alexrallen mentioned this pull request Jun 14, 2021
Merged
lguohan pushed a commit that referenced this pull request Jun 17, 2021
@alexrallen
[sonic-utilities] submodule update (#7799)
f39fc88 
19615e3 Fixing db_migrator for Feature table (#1674)
d1c1c61 [tests]: skip some dynamic port breakout unit tests (#1677)
25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (#1675)
3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (#1663)
a425ca2 [config] support for configuring muxcable to manual mode of operation  (#1642)
25e17de [show platform summary] Add chassis hardware info to platform summary and version (#1624)
f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (#1635)
56db162 [config] Fix config int add incorrect ip (#1414)
1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (#1564)
c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (#1638)
cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (#1620)
5f20365 Change to use rvtysh when calling the show commands (#1572)
51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (#1625)
18bed46 [console][show] Force refresh all lines status during show line (#1641)
b616cd9 [TPID CONFIG] Added TPID configuration CLI support (#1618)
01eb4b1 [show] support for show muxcable firmware version of only active banks (#1629)
7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (#657)
e23c5ee Add psu hardware revision to psushow table (#1601)
f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (#1614)
5d1ad05 [show] add support for muxcable metrics (#1615)
feeab29 [config] Sort Config Db When Saving (#1623)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@alexrallen
[sonic-utilities] submodule update (sonic-net#7799)
ca0264b 
19615e3 Fixing db_migrator for Feature table (sonic-net#1674)
d1c1c61 [tests]: skip some dynamic port breakout unit tests (sonic-net#1677)
25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (sonic-net#1675)
3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663)
a425ca2 [config] support for configuring muxcable to manual mode of operation  (sonic-net#1642)
25e17de [show platform summary] Add chassis hardware info to platform summary and version (sonic-net#1624)
f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (sonic-net#1635)
56db162 [config] Fix config int add incorrect ip (sonic-net#1414)
1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (sonic-net#1564)
c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (sonic-net#1638)
cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (sonic-net#1620)
5f20365 Change to use rvtysh when calling the show commands (sonic-net#1572)
51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (sonic-net#1625)
18bed46 [console][show] Force refresh all lines status during show line (sonic-net#1641)
b616cd9 [TPID CONFIG] Added TPID configuration CLI support (sonic-net#1618)
01eb4b1 [show] support for show muxcable firmware version of only active banks (sonic-net#1629)
7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (sonic-net#657)
e23c5ee Add psu hardware revision to psushow table (sonic-net#1601)
f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (sonic-net#1614)
5d1ad05 [show] add support for muxcable metrics (sonic-net#1615)
feeab29 [config] Sort Config Db When Saving (sonic-net#1623)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@stephenxs
Enhance dynamic buffer calculation and bug fixes (sonic-net#1601)
f4c3579 
* Enhancement and bug fixes for dynamic buffer calculation

What I did
- Remove make_pair when calling emplace_back.
- The pool size isn't recalculated when a port with headroom override but without speed or cable length configured being shutdown.
- Remove the current PG from the old referenced profile only if its name isn't empty, otherwise an entry with empty name will be inserted into m_bufferProfileLookup
- Don't try removing statically configured profiles with dynamic headroom from the APPL_DB because they were not programmed to APPL_DB.
- Setting a buffer PG to the same profile as it was causes the referenced dynamic profile unable to be removed once it isn't referenced any more

How I verified it
Run regression and vs test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@alexrallen
Add psu hardware revision to psushow table (sonic-net#1601)
e23c5ee 
- What I did
Added a field for hardware revision to the psushow output table.

- How I did it
Defined new psu status field sourced from "revision" field in STATE_DB added in alexrallen/sonic-platform-daemons#1 and adds it to the table output with the header "HW Rev"

All relevant unit tests were also updated.

- How to verify it
Execute show platform psustatus and verify that "HW Rev" column is present and appropriately populated depending on the platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keboliu