Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the clean target reporting "Is a directory" error #16029

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

saiarcot895
Copy link
Contributor

@saiarcot895 saiarcot895 commented Aug 4, 2023

Why I did it

Since directories are being removed, the -r flag is required.

Fixes #15922

Work item tracking
  • Microsoft ADO (number only): 24752770

How I did it

How to verify it

After fully building an image, run make clean, and verify there are no errors.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Since directories are being removed, the `-r` flag is required.

Fixes sonic-net#15922

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@k-v1
Copy link
Contributor

k-v1 commented Aug 8, 2023

Yes, need to fix this issue.
My PR with the same fix was probably lost.
#14406

@qiluo-msft qiluo-msft merged commit dfe5ea6 into sonic-net:master Aug 14, 2023
16 checks passed
@saiarcot895 saiarcot895 deleted the fix-clean branch August 14, 2023 18:38
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
### Why I did it

Since directories are being removed, the `-r` flag is required.

Fixes sonic-net#15922

##### Work item tracking
- Microsoft ADO **(number only)**: 24752770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make clean failed with an error on sonic-buildimage
3 participants