Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensormond support #16089

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Sensormond support #16089

merged 4 commits into from
Feb 24, 2024

Conversation

bmridul
Copy link
Contributor

@bmridul bmridul commented Aug 10, 2023

Why I did it

Enable Sensormon daemon in PMON container.
Pls see HLD : sonic-net/SONiC#1394

Work item tracking
  • Microsoft ADO (number only):

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

202205

Description for the changelog

Support for including Sensormon daemon in PMON.

Link to config_db schema for YANG module changes

N.A.

A picture of a cute animal (not mandatory but encouraged)

@abdosi
Copy link
Contributor

abdosi commented Sep 7, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bmridul
Copy link
Contributor Author

bmridul commented Sep 12, 2023

@abdosi, can u help merge the PR.

@lguohan lguohan added the pmon label Sep 23, 2023
abdosi
abdosi previously approved these changes Sep 25, 2023
@abdosi
Copy link
Contributor

abdosi commented Sep 25, 2023

@lguohan / @prgeor can you please help review and merge of this.

@prgeor
Copy link
Contributor

prgeor commented Sep 27, 2023

@lguohan / @prgeor can you please help review and merge of this.

@abdosi HLD is pending review/approve

@prgeor
Copy link
Contributor

prgeor commented Sep 27, 2023

@abdosi we already have sensord running for monitoring various sensors. we should try to get other sensors also in sensord

Copy link
Contributor

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmridul please resolve open comments for the HLD https://github.com/sonic-net/SONiC/pull/1394/files

@bmridul
Copy link
Contributor Author

bmridul commented Oct 27, 2023

@bmridul please resolve open comments for the HLD https://github.com/sonic-net/SONiC/pull/1394/files

@prgeor , I have addressed open comments on the HLD. Pls check.

@prgeor
Copy link
Contributor

prgeor commented Dec 4, 2023

@bmridul please resolve open comments for the HLD https://github.com/sonic-net/SONiC/pull/1394/files

@prgeor , I have addressed open comments on the HLD. Pls check.

@bmridul please check the HLD comment

@shivuv
Copy link

shivuv commented Dec 21, 2023

@gechiang @abdosi : Can you please add a label to cherry pick this into 202305 and 202311 branches ?

@abdosi
Copy link
Contributor

abdosi commented Dec 29, 2023

@prgeor do we still have any comment on this PR ? Are we ok to signoff on this ?

@prgeor
Copy link
Contributor

prgeor commented Feb 6, 2024

@prgeor do we still have any comment on this PR ? Are we ok to signoff on this ?

@abdosi still waiting on comment to be resolved

@abdosi
Copy link
Contributor

abdosi commented Feb 16, 2024

@lguohan : can you please help with merge of this.

@prgeor
Copy link
Contributor

prgeor commented Feb 23, 2024

@rlhui can you merge

@rlhui rlhui merged commit 54c1a49 into sonic-net:master Feb 24, 2024
19 checks passed
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
Enable Sensormon daemon in PMON container.
Pls see HLD : sonic-net/SONiC#1394
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
Enable Sensormon daemon in PMON container.
Pls see HLD : sonic-net/SONiC#1394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants