platform/cavium : Download debian packages #162
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,20 @@ | ||
| # Cavium SAI | ||
|
|
||
| CAVM_SAI_GITHUB = https://github.com/garyachy/OpenXPS/raw/sai_0.9.5/SAI/cavm-sai/ | ||
|
|
||
| CAVM_LIBSAI = libsai.deb | ||
| CAVM_SAI = sai.deb | ||
| XP_TOOLS = xp-tools.deb | ||
| XPSHELL = xpshell.deb | ||
|
|
||
| $(CAVM_LIBSAI)_URL = $(CAVM_SAI_GITHUB)/$(CAVM_LIBSAI) | ||
| $(CAVM_SAI)_URL = $(CAVM_SAI_GITHUB)/$(CAVM_SAI) | ||
| $(XP_TOOLS)_URL = $(CAVM_SAI_GITHUB)/$(XP_TOOLS) | ||
| $(XPSHELL)_URL = $(CAVM_SAI_GITHUB)/$(XPSHELL) | ||
| SONIC_ONLINE_DEBS += $(CAVM_LIBSAI) $(CAVM_SAI) $(XP_TOOLS) $(XPSHELL) | ||
|
|
||
| #$(CAVM_LIBSAI)_PATH = $(PLATFORM_PATH)/cavm_sdk | ||
|
There was a problem hiding this comment. Why still keep those lines? There was a problem hiding this comment. We need this for debug purpose There was a problem hiding this comment. You can just copy files to target/debs, and make won't try to download them even if they are in SONIC_ONLINE_DEBS group. |
||
| #$(CAVM_SAI)_PATH = $(PLATFORM_PATH)/cavm_sdk | ||
| #$(XP_TOOLS)_PATH = $(PLATFORM_PATH)/cavm_sdk | ||
| #$(XPSHELL)_PATH = $(PLATFORM_PATH)/cavm_sdk | ||
| #SONIC_COPY_DEBS += $(CAVM_LIBSAI) $(CAVM_SAI) $(XP_TOOLS) $(XPSHELL) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these files going to be updated within same branch?
If yes, use commit hash in URL instead of branch name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always are going to use latest and greatest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If, for instance, SAI headers are changed, you won't be able to compile older version of SONiC.
But it's up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cavium provides both SAI headers and SAI adapter library.
In case if SONIC is upgraded to use SAI 1.0 headers, Cavium build will be broken until we change both our SAI headers and SAI adapter library.
Anyway, thanks for your review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I think sonic uses sai 0.9.4 branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it's better to use commit hash instead of branch name. You can always update your sai binaries to the latest and greatest in your git repo meanwhile update the url on this repo. I think it is easier for us the debug as when something is broken for cavium platform, we will know for sure whether it is because sai package update or sonic update.