Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp/dhcpv6 per interface counter support #16377

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

jcaiMR
Copy link
Contributor

@jcaiMR jcaiMR commented Sep 1, 2023

Why I did it

Support DHCP/DHCPv6 per-interface counter, code change in sonic-build image.

Work item tracking
  • Microsoft ADO (17271822):

How I did it

  1. Introduce libjsoncpp-dev in dhcpmon and dhcprelay repo
  2. Show CLI changes after counter format change

How to verify it

  1. Manually run show command
  2. dhcpmon, dhcprelay integration tests

Example of show cli output

       Message Type    Ethernet156(RX)
-------------------  -----------------
            Unknown                  0
            Solicit                  0
          Advertise                  0
            Request                  0
            Confirm                  0
              Renew                  0
             Rebind                  0
              Reply                  0
            Release                  0
            Decline                  0
        Reconfigure                  0
Information-Request                  0
      Relay-Forward                  0
        Relay-Reply                  0
          Malformed                  0

       Message Type    Ethernet156(TX)
-------------------  -----------------
            Unknown                  0
            Solicit                  0
          Advertise                  0
            Request                  0
            Confirm                  0
              Renew                  0
             Rebind                  0
              Reply                  0
            Release                  0
            Decline                  0
        Reconfigure                  0
Information-Request                  0
      Relay-Forward                  0
        Relay-Reply                  0
          Malformed                  0

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@jcaiMR jcaiMR marked this pull request as ready for review September 4, 2023 13:03
@jcaiMR jcaiMR requested a review from lguohan as a code owner September 4, 2023 13:03
@lguohan lguohan merged commit a522a63 into sonic-net:master Sep 5, 2023
17 checks passed
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
)

Why I did it
Support DHCP/DHCPv6 per-interface counter, code change in sonic-build image.

Work item tracking
Microsoft ADO (17271822):

How I did it
- Introduce libjsoncpp-dev in dhcpmon and dhcprelay repo
- Show CLI changes after counter format change

How to verify it
- Manually run show command
- dhcpmon, dhcprelay integration tests
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Oct 20, 2023
)

Why I did it
Support DHCP/DHCPv6 per-interface counter, code change in sonic-build image.

Work item tracking
Microsoft ADO (17271822):

How I did it
- Introduce libjsoncpp-dev in dhcpmon and dhcprelay repo
- Show CLI changes after counter format change

How to verify it
- Manually run show command
- dhcpmon, dhcprelay integration tests
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16960

mssonicbld pushed a commit that referenced this pull request Oct 21, 2023
Why I did it
Support DHCP/DHCPv6 per-interface counter, code change in sonic-build image.

Work item tracking
Microsoft ADO (17271822):

How I did it
- Introduce libjsoncpp-dev in dhcpmon and dhcprelay repo
- Show CLI changes after counter format change

How to verify it
- Manually run show command
- dhcpmon, dhcprelay integration tests
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 22, 2024
)

Why I did it
Support DHCP/DHCPv6 per-interface counter, code change in sonic-build image.

Work item tracking
Microsoft ADO (17271822):

How I did it
- Introduce libjsoncpp-dev in dhcpmon and dhcprelay repo
- Show CLI changes after counter format change

How to verify it
- Manually run show command
- dhcpmon, dhcprelay integration tests
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #17871

mssonicbld pushed a commit that referenced this pull request Jan 22, 2024
Why I did it
Support DHCP/DHCPv6 per-interface counter, code change in sonic-build image.

Work item tracking
Microsoft ADO (17271822):

How I did it
- Introduce libjsoncpp-dev in dhcpmon and dhcprelay repo
- Show CLI changes after counter format change

How to verify it
- Manually run show command
- dhcpmon, dhcprelay integration tests
kellyyeh added a commit to kellyyeh/sonic-buildimage that referenced this pull request Mar 5, 2024
yaqiangz added a commit to yaqiangz/sonic-buildimage that referenced this pull request May 31, 2024
yxieca pushed a commit that referenced this pull request Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit that referenced this pull request Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit that referenced this pull request Sep 7, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants