-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special rsyslog filter for MSN2700 platform #16684
Add special rsyslog filter for MSN2700 platform #16684
Conversation
@keboliu can we use sensord configuration file to ignore the sensor reading? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keboliu to prevent overwhelming the host rsyslogd, please do the filtering inside the PMON. To make this working in PMON, we need to keep this action at the end of the rsyslog conf file:-https://github.com/sonic-net/sonic-buildimage/blob/master/files/image_config/rsyslog/rsyslog-container.conf.j2#L56
I tried to add the rule to the rsyslog.conf inside pmon docker, but it doesn't work. |
…_64-mlnx_msn2700a1-r0 platforms Signed-off-by: Kebo Liu <kebol@nvidia.com>
ad483c3
to
c6fe8e9
Compare
@saiarcot895 could you review? |
@liat-grozovik @lguohan please merge |
@yxieca @StormLiangMS would you please help to cherry-pick? |
- Why I did it Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/sonic-net#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely. - How I did it Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf - How to verify it run regression on the MSN2700 platform to make the error log will not be printed to the syslog. Signed-off-by: Kebo Liu <kebol@nvidia.com>
6 similar comments
Hi, @StormLiangMS. It seems that some openssh version related fix is not included in the 202211 branch and are causing a build fail, would you please help to check? |
1 similar comment
Hi @keboliu next time, pls have the tested branch info updated in the description part if need cherry pick to old branches. |
- Why I did it Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/sonic-net#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely. - How I did it Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf - How to verify it run regression on the MSN2700 platform to make the error log will not be printed to the syslog. Signed-off-by: Kebo Liu <kebol@nvidia.com>
Cherry-pick PR to 202305: #17078 |
Why I did it
Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely.
Work item tracking
How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf
How to verify it
run regression on the MSN2700 platform to make the error log will not be printed to the syslog.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)