-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Move /var/log to RAM for Mellanox SN2700, Nokia 7215 and Dell S6100 #16775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… S6100 (sonic-net#15077)" This reverts commit 05f326e.
Junchao-Mellanox
approved these changes
Oct 7, 2023
dgsudharsan
approved these changes
Oct 9, 2023
@assrinivasan @prgeor Can you please add labels to branches where the revert needs to be backported? |
prgeor
approved these changes
Oct 9, 2023
@Blueve Please review the 7215 change. Thanks. |
assrinivasan
changed the title
Revert "Move /var/log to RAM for Mellanox SN2700, Nokia 7215 and Dell…
Revert "Move /var/log to RAM for Mellanox SN2700, Nokia 7215 and Dell S6100
Oct 11, 2023
@yxieca LGTM |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 14, 2023
… S6100 (sonic-net#15077)" (sonic-net#16775) This reverts commit 05f326e. Microsoft ADO 25355843:
Cherry-pick PR to 202205: #16886 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Oct 14, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
Oct 14, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 17, 2023
… S6100 (sonic-net#15077)" (sonic-net#16775) This reverts commit 05f326e. Microsoft ADO 25355843:
Cherry-pick PR to 202305: #16915 |
11 tasks
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Oct 17, 2023
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jun 4, 2024
…and Dell S6100 (sonic-net#15077)" (sonic-net#16775)" This reverts commit 61683d9. Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 05f326e.
Why I did it
Mellanox raised concerns about PR15077. So, we need to revert it.
Work item tracking
How I did it
By calling git revert on commit SHA 05f326e, which is PR #15077 , and fixing merge conflicts on Dell's installer.conf file.
How to verify it
Check that the files modified by aforementioned PR does not have log_inram config.
Build and flash images with this config then verify the following:
Dell S6100
Mellanox SN2700
Nokia 7215
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)