Update sonic-yang model to take in EdgeZoneAggregator as a device #16974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
approved these changes
Oct 23, 2023
qiluo-msft
approved these changes
Oct 27, 2023
ganglyu
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Nov 1, 2023
What I did Add unit test for db_migrator.py: ConfigDB passing yang validation. Microsoft ADO: 24657445 Pending on sonic-net/sonic-buildimage#16974 How I did it Add yang validation for unit test, and fix test data to pass yang validation. How to verify it Run sonic-utilities end to end test.
ganglyu
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Dec 18, 2023
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
Add unit test for db_migrator.py: ConfigDB passing yang validation.
Microsoft ADO: 24657445
Pending on sonic-net/sonic-buildimage#16974
#### How I did it
Add yang validation for unit test, and fix test data to pass yang validation.
#### How to verify it
Run sonic-utilities end to end test.
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
ganglyu
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Dec 18, 2023
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
Add unit test for db_migrator.py: ConfigDB passing yang validation.
Microsoft ADO: 24657445
Pending on sonic-net/sonic-buildimage#16974
#### How I did it
Add yang validation for unit test, and fix test data to pass yang validation.
#### How to verify it
Run sonic-utilities end to end test.
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We use
EdgeZoneAggregatorindb_migrator, but we don't support this pattern in sonic yang models. Hence, we update this in the sonic-yang model.Work item tracking
How I did it
Update the device pattern list.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Update sonic-yang model to take in EdgeZoneAggregator as a device
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)