Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect config_db.json from minigraph misconfig #1727

Merged
merged 23 commits into from
May 24, 2018
Merged

Protect config_db.json from minigraph misconfig #1727

merged 23 commits into from
May 24, 2018

Commits on May 17, 2018

  1. Add noise config for PortChannel & EthernetInterface in simple-sample… 

    …-graph.xml
    @wendani
    wendani committed May 17, 2018
    Configuration menu
    Copy the full SHA
    b9f2080 View commit details
    Browse the repository at this point in the history

  2. Add noise config for PORTCHANNEL_INTERFACE in simple-sample-graph.xml 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 17, 2018
    Configuration menu
    Copy the full SHA
    696e791 View commit details
    Browse the repository at this point in the history

  3. Add noice config for DEVICE_NEIGHBOR in t0-sample-graph.xml 

    Add unit test against introducing ports not existing in port_config.ini
into DEVICE_NEIGHBOR

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 17, 2018
    Configuration menu
    Copy the full SHA
    b5e43d6 View commit details
    Browse the repository at this point in the history

  4. DeviceInterfaceLink in minigraph.xml can contain port not existing in 

    port_config.ini but contraining non-zero Bandwidth attribute

Add noice config in simple-sample-graph.xml to capture the case that
such a port is leaked into config_db.json

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 17, 2018
    Configuration menu
    Copy the full SHA
    f3c97e0 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. Protect PORTCHANNEL from ports not existing in port_config.ini 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6518266 View commit details
    Browse the repository at this point in the history

  2. Protect PORTCHANNEL_INTERFACE from portchannels containing ports not 

    existing in port_config.ini

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    097f1e9 View commit details
    Browse the repository at this point in the history

  3. Protect DEVICE_NEIGHBOR from ports not existing in port_config.ini 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    1f293e2 View commit details
    Browse the repository at this point in the history

  4. Add noise config Ethernet1 in DeviceInterfaceLinks in simple-sample-g… 

    …raph.xml as it is in PortChannel1001

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6db9a0a View commit details
    Browse the repository at this point in the history

  5. Add noise config Ethernet1 in DeviceInterfaceLinks in simple-sample-g… 

    …raph.xml as it is in PortChannel1001

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    987bc92 View commit details
    Browse the repository at this point in the history

  6. Protect PORTCHANNEL from ports not existing in port_config.ini 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    9021233 View commit details
    Browse the repository at this point in the history

  7. Protect PORTCHANNEL_INTERFACE from portchannels containing ports not 

    existing in port_config.ini

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    d604685 View commit details
    Browse the repository at this point in the history

  8. Protect DEVICE_NEIGHBOR from ports not existing in port_config.ini 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    c9f22b3 View commit details
    Browse the repository at this point in the history

  9. Correct space in minigraph.py 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    955e4be View commit details
    Browse the repository at this point in the history

  10. Does not allow non-port_config.ini port to get into the port list 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    1e79656 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'config_db_protect_master' into sample_graph_master

    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    f545f41 View commit details
    Browse the repository at this point in the history

  12. Check PORTCHANNEL against PORT list only if port_config_file exists 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6c3026a View commit details
    Browse the repository at this point in the history

  13. Correct format 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 18, 2018
    Configuration menu
    Copy the full SHA
    8caa011 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. print warning when a port coming from DeviceInterfaceLink is not in 

    port_config.ini

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 19, 2018
    Configuration menu
    Copy the full SHA
    37f1f81 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. Change Ethernet1 and 2 to fortyGigE0/1 and 2,respectively 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 22, 2018
    Configuration menu
    Copy the full SHA
    472c499 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fortyGigE' into sample_graph_master

    @wendani
    wendani committed May 22, 2018
    Configuration menu
    Copy the full SHA
    8efa34d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. Change Ethernet1 and 2 to fortyGigE0/1 and 2,respectively 

    Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 23, 2018
    Configuration menu
    Copy the full SHA
    c3c46ba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fortyGigE' into sample_graph_master

    @wendani
    wendani committed May 23, 2018
    Configuration menu
    Copy the full SHA
    75a35fa View commit details
    Browse the repository at this point in the history

  3. print warning when ignoring ports, portchannels, portchannel interfac… 

    …es, and

device neighbors

Update t0-sample-graph.xml with interface name 'fortyGigE0/2' and the
ACL_TABLE output

Signed-off-by: Wenda <wenni@microsoft.com>
    @wendani
    wendani committed May 23, 2018
    Configuration menu
    Copy the full SHA
    293ac1a View commit details
    Browse the repository at this point in the history