[yang][smartswitch] Add YANG model for MID_PLANE_BRIDGE and DPU tables. #17311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
reviewed
Nov 28, 2023
11 tasks
dgsudharsan
approved these changes
Nov 28, 2023
yaqiangz
reviewed
Nov 29, 2023
Merged
11 tasks
|
@yaqiangz could you please review following the changes? |
|
@ganglyu Could you help to review this PR? |
ganglyu
reviewed
Dec 8, 2023
| } | ||
| } | ||
|
|
||
| leaf midplane_interface { |
There was a problem hiding this comment.
midplane_interface value is the same as dpu_name, why do we still need this leaf?
There was a problem hiding this comment.
dpu_name is a key of the table and represents the name of the DPU.
midplane_interface is the attribute of the DPU and represents the name of the midplane (PCIe) interface.
Even though they share the same name (for convenience) they represent the different entities.
|
Would you please update src/sonic-yang-models/doc/Configuration.md? |
oleksandrivantsiv
force-pushed
the
smartswitch-yang
branch
from
4183906
to
bee9588
Compare
@ganglyu done |
ganglyu
approved these changes
Dec 13, 2023
liat-grozovik
approved these changes
Dec 14, 2023
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 17311 in repo sonic-net/sonic-buildimage |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add the YANG model according to Smart Switch IP address assignment HDL.
Work item tracking
How I did it
Implement new YANG model containers.
How to verify it
Run YANG model unit tests. The changes add new unit tests to cover new functionality.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)