Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] Disable MFT bash autocompletion #17442

Merged
merged 1 commit into from
Dec 10, 2023
Merged

[Mellanox] Disable MFT bash autocompletion #17442

merged 1 commit into from
Dec 10, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Dec 7, 2023 •
edited by liat-grozovik
Loading

A W/A to overcome delay of about 20 sec on login due to MFT bash autocompletion bug.
Should be reverted once a formal solution will be available in future MFT release.

Why I did it

  • To overcome SN2700 20 sec delay on login
Work item tracking
  • N/A

How I did it

  • Removed MFT bash autocompletion part

How to verify it

  1. Build a mellanox image
  2. Verify no such links after system boot.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • master

Description for the changelog

  • N/A

Link to config_db schema for YANG module changes

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig
[mellanox]: Disable MFT bash autocompletion.
042f3c2 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
This was referenced Dec 7, 2023
Merged
Merged
Merged
@nazariig nazariig marked this pull request as ready for review December 7, 2023 17:29
@liat-grozovik liat-grozovik changed the title [mellanox]: Disable MFT bash autocompletion. [Mellanox]: Disable MFT bash autocompletion. Dec 8, 2023
@liat-grozovik liat-grozovik merged commit 278a958 into sonic-net:master Dec 10, 2023
19 checks passed
@liat-grozovik liat-grozovik changed the title [Mellanox]: Disable MFT bash autocompletion. [Mellanox] Disable MFT bash autocompletion Dec 10, 2023
@dgsudharsan
Copy link
Collaborator

@StormLiangMS This is included in 202305 branch. #17359 Can you please add the label?

@nazariig nazariig mentioned this pull request Dec 17, 2023
Merged
10 tasks
nazariig added a commit to nazariig/sonic-buildimage that referenced this pull request Mar 18, 2024
@nazariig
Revert "[Mellanox] Disable MFT bash autocompletion (sonic-net#17442)"
1baebd4 
This reverts commit 278a958.
yxieca pushed a commit that referenced this pull request Mar 22, 2024
@nazariig
[Mellanox][MFT]: Update MFT to 4.27.0-83: bash login fix (#18443)
009b029 
* Revert "[Mellanox] Disable MFT bash autocompletion (#17442)"

This reverts commit 278a958.

* [mellanox][mft]: Update MFT to 4.27.0-83: bash login fix.

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

---------

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@liuh-80 liuh-80 liuh-80 approved these changes

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

@dgsudharsan dgsudharsan Awaiting requested review from dgsudharsan

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Bug 🐛 Cherry Pick Conflict_202205 Cherry Pick Conflict_202211 Cherry Pick Conflict_202305 Cherry Pick Conflict_202311 Included in 202305 Branch Included in 202311 Branch Platform: Mellanox Request for 202205 Branch Request for 202211 Branch Request for 202305 Branch Request for 202311 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nazariig @dgsudharsan @liat-grozovik @liuh-80 @keboliu @StormLiangMS