Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syncd_request_shutdown coredump in config reload on KVM sonic #17486

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

jimmyzhai
Copy link
Contributor

Why I did it

The issue is related to #16812. Process syncd does not run in the container gbsyncd on kvm sonic with default hwsku.

Work item tracking
  • Microsoft ADO : 26151608

How I did it

If syncd has not run in container gbsyncd, it is not needed to trigger graceful shudown of syncd.

How to verify it

None of syncd_request_shutdown coredump in config reload on KVM sonic

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan merged commit 53be9de into sonic-net:master Dec 14, 2023
21 checks passed
@mssonicbld
Copy link
Collaborator

@jimmyzhai PR conflicts with 202311 branch

@yxieca
Copy link
Contributor

yxieca commented Dec 14, 2023

@jimmyzhai can you help with 202311 cherry-picking?

@liushilongbuaa
Copy link
Contributor

@yxieca , it seems that a previous PR is needed to approve first: #16812

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 19, 2023
…nic-net#17486)

The issue is related to sonic-net#16812. Process syncd does not run in the container gbsyncd on kvm sonic with default hwsku.

Microsoft ADO : 26151608

How I did it
If syncd has not run in container gbsyncd, it is not needed to trigger graceful shudown of syncd.

How to verify it
None of syncd_request_shutdown coredump in config reload on KVM sonic
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #17564

@jimmyzhai
Copy link
Contributor Author

@jimmyzhai can you help with 202311 cherry-picking?

Manually cherry-picked by #17563.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants