[caclmgrd] Heuristically determine whether ACL is IPv4 or IPv6, use iptables/ip6tables accordingly #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptables/ip6tables accordingly
prsunny
reviewed
Jun 5, 2018
files/image_config/caclmgrd/caclmgrd
Outdated
| # do it now. We determine heuristically based on whether the | ||
| # src IP is a v4 or v6 address. | ||
| if not table_ip_version: | ||
| if "SRC_IP" in rule_props and rule_props["SRC_IP"]: |
There was a problem hiding this comment.
if SRC_IP is not specified, does the ACL need to be applied to both iptables AND ip6tables?
There was a problem hiding this comment.
No. We assume that with regard to service ACLS, IPv4 and IPv6 ACLs will be stored in separate tables. If a rule needs to be applied to both IPv4 and IPv6, it needs to be specified twice, one in a v4 table and once in a v6 table.
However, I realize that this implementation also assumes that the first rule in the table will always have a SRC_IP defined. If not, then the table will be assumed to be v4, whether or not subsequent rules have v6 SRC_IPs. This may not always be true. #Fixed in commit 250155c
lguohan
approved these changes
Jun 5, 2018
lguohan
pushed a commit
that referenced
this pull request
Jun 5, 2018
…ptables/ip6tables accordingly (#1767) * [caclmgrd] Heuristically determine whether ACL is IPv4 or IPv6, use iptables/ip6tables accordingly * Check all rules in table until we find one with a SRC_IP
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…t cleanup fix (sonic-net#1767) * Clean up: Remove rif in test_portchannel.py Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.