Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swss/syncd]: Remove dependency on interfaces-config.service #17739

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

nazariig
Copy link
Collaborator

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

This improvement does not bring any warm-reboot degradation, since the database availability (tcp/ip access over the loopback interface) was fixed by these PRs:

Why I did it

  • Removed dependency on interfaces-config.service to speed up the boot, because interfaces-config.service takes a lot of time on init
Work item tracking
  • N/A

How I did it

  • Changed service files for swss/syncd

How to verify it

  • Boot and check swss/syncd start time comparing to interfaces-config

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • master

Description for the changelog

  • N/A

Link to config_db schema for YANG module changes

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny requested a review from yxieca January 18, 2024 01:30
@prsunny
Copy link
Contributor

prsunny commented Jan 18, 2024

@yxieca to signoff/merge

@yxieca yxieca merged commit e173987 into sonic-net:master Jan 18, 2024
23 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 31, 2024
…et#17739)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #17964

mssonicbld pushed a commit that referenced this pull request Feb 1, 2024
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com>
@StormLiangMS
Copy link
Contributor

Hi @nazariig, 202305 is done, any justification for necessary to pick up this?

@nazariig
Copy link
Collaborator Author

Hi @nazariig, 202305 is done, any justification for necessary to pick up this?

@StormLiangMS it is already in 202305. Just need a label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants