Commits on Jan 17, 2024

1. dhcrelay: Don't look up the ifindex for the fallback interface …

   Currently, whenever isc-dhcp-relay forwards a packet upstream,
   internally, it will try to send it on a "fallback" interface. My
   understanding is that this isn't meant to be a real interface, but
   instead is basically saying to use Linux's regular routing stack to
   route the packet appropriately (rather than having isc-dhcp-relay
   specify specifically which interface to use).
   
   The problem is that on systems with a weak CPU, a large number of
   interfaces, and many upstream servers specified, this can introduce a
   noticeable delay in packets getting sent. The delay comes from trying to
   get the ifindex of the fallback interface. In one test case, it got to
   the point that only 2 packets could be processed per second. Because of
   this, dhcrelay will easily get backlogged and likely get to a point
   where packets get dropped in the kernel.
   
   Fix this by adding a check saying if we're using the fallback interface,
   then don't try to get the ifindex of this interface. We're never going
   to have an interface named this in SONiC.
   
   Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

   

   saiarcot895 committed Jan 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c6b3e9f
   • Browse repository at this point

   Copy the full SHA

   c6b3e9f View commit details

   Browse the repository at this point in the history