Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp-server] Change the kea-dhcp4 PID file directory to tmpfs. #17974

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

oleksandrivantsiv
Copy link
Collaborator

Why I did it

Fix the issue with running "dhcp-server-ipv4:kea-dhcp4" process after a cold reboot: #17948

Work item tracking
  • Microsoft ADO (number only):

How I did it

The root cause of the issue is that during the cold reboot, the PID file of the process (that is stored on the persisted FS) is not cleared. From the KEA DHCP server documentation:

If the file already exists and contains the PID of a live process, the server issues a DHCP4_ALREADY_RUNNING log message and exits. It is possible, though unlikely, that the file is a remnant of a system crash and the process to which the PID belongs is unrelated to Kea. In such a case, it would be necessary to manually delete the PID file.

To make sure that the PID file is always cleared during the dhcp-server container restart the PID file should be stored on the tmpfs.

How to verify it

Go over the steps to reproduce described in #17948.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@oleksandrivantsiv oleksandrivantsiv requested review from yaqiangz and removed request for lguohan January 31, 2024 23:20
Copy link
Contributor

@yaqiangz yaqiangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@yaqiangz
Copy link
Contributor

yaqiangz commented Feb 1, 2024

MSFT ADO number: 26640026

@yaqiangz
Copy link
Contributor

yaqiangz commented Feb 5, 2024

@yxieca Could you please help to merge this PR?

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #18116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants