Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix docker container name to syslog syslogtag (program name) #1810

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

qiluo-msft
Copy link
Collaborator

Refine syslog in host system file and forwarded message to remote server
Before:

Jun 23 06:00:41.207694 sonic INFO snmp-subagent [ax_interface] INFO: OID registration complete. Waiting to receive PDUs...
Jun 23 06:00:44.800044 sonic INFO supervisord 2018-06-23 06:00:35,789 INFO success: rsyslogd entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)

After:

Jun 23 06:00:41.207694 sonic INFO snmp/snmp-subagent [ax_interface] INFO: OID registration complete. Waiting to receive PDUs...
Jun 23 06:00:44.800044 sonic INFO snmp/supervisord 2018-06-23 06:00:35,789 INFO success: rsyslogd entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@qiluo-msft qiluo-msft merged commit 7ba08e5 into sonic-net:master Jun 25, 2018
@qiluo-msft qiluo-msft deleted the qiluo/dockersyslog branch June 25, 2018 17:48
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Nov 1, 2021
```
ca728b8 [config] fix interface IPv6 address removal. (sonic-net#1819)
0665d6f VxLAN Tunnel Counters and Rates implementation (sonic-net#1748)
80a10dc Fix log_ssd_health hang issue (sonic-net#1904)
ea4a730 [config][cbf] Added config commands for CBF (sonic-net#1799)
02ce8d6 [sonic-package-manager] update FEATURE entries on upgrade (sonic-net#1803)
9f123c0 [generate_dump] remove secrets from dump files (sonic-net#1886)
3a8ab73 [fwutil] Add `fwutil update all` to support the automatic platform component fw updates (sonic-net#1242)
776fddf [sonic-package-manager] code style fixes and enhancements (sonic-net#1802)
f53baac [watermarkstat] Fix for error in processing empty array from couters db (sonic-net#1810)
0b2536b Generic_upater: Apply JSON change (sonic-net#1856)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Nov 2, 2021
```
ca728b8 [config] fix interface IPv6 address removal. (#1819)
0665d6f VxLAN Tunnel Counters and Rates implementation (#1748)
80a10dc Fix log_ssd_health hang issue (#1904)
ea4a730 [config][cbf] Added config commands for CBF (#1799)
02ce8d6 [sonic-package-manager] update FEATURE entries on upgrade (#1803)
9f123c0 [generate_dump] remove secrets from dump files (#1886)
3a8ab73 [fwutil] Add `fwutil update all` to support the automatic platform component fw updates (#1242)
776fddf [sonic-package-manager] code style fixes and enhancements (#1802)
f53baac [watermarkstat] Fix for error in processing empty array from couters db (#1810)
0b2536b Generic_upater: Apply JSON change (#1856)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
judyjoseph added a commit that referenced this pull request Nov 14, 2021
sonic-snmpagent
7e46eb1 [201911][RFC1213]: Initialize lag oid map in reinit_data (#234)
aa98ded CPU Spike because of redundant and flooded keyspace notifis handled (#230)

sonic-swss
bc4e334 [Mux orch] Handle setting unknown mux state (#1984)
bd3630b [tunnel decap] Change tunnel orch order (#1977)
87a673a Fix the option missing in kernel config issue (#1973)
57967a1 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (#1967)

sonic-utilities
181e8b0 Fix the option missing in kernel config issue (#1888)
21c0cc0 [watermarkstat] Fix for error in processing empty array from couters db (#1810)
7f15755 [chassis][supervisor][show][interfaces]show interfaces command warning on Supervisor card (#1771)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
…db (sonic-net#1810)

With switch to swsscommon, the get operations return NULL ('') if there
are no entries in any table. But the existing code for handling counters
values in the case of absence of entries assumes that the get operations
return 'None', which was the case with swsssdk. This was causing
problem.

For PG_WATERMARK_STAT_COUNTER SAI does not support
SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES and
SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES. So there are no
objects in the counters db. With swsscommon, in the absence of objects,
an empty string ('') is returned instead of 'None'. The code expecting
'None' tries to converts the empty string to integer and throws error.
This is fixed by adding check for empty string in addition to 'None'.

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants