Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports FRR-VRRP configuration #18617

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

philo-micas
Copy link
Contributor

@philo-micas philo-micas commented Apr 10, 2024

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

hld:sonic-net/SONiC#1446

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: philo <philo@micasnetworks.com>
philo-micas and others added 5 commits April 17, 2024 15:53
Signed-off-by: philo <philo@micasnetworks.com>
Signed-off-by: philo <philo@micasnetworks.com>
…28-support-vrrp6-commands-and-tracking-interface.patch
@philo-micas philo-micas marked this pull request as ready for review May 7, 2024 01:55
philo-micas and others added 5 commits July 26, 2024 09:46
…30-support-vrrp6-commands-and-tracking-interface.patch
Signed-off-by: philo <philo@micasnetworks.com>
Signed-off-by: philo <philo@micasnetworks.com>
PROXY_SERVER_ADDR = '/etc/frr/vrrpd_client_sock'
ALL_DAEMONS = ['vrrpd']
TABLE_DAEMON = {
'VRRP': ['vrrpd'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, we discussed to have VRRP config handler for FRR as part of frrcfgd itself, what are we doing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have also implemented this functionality in frrcfgd. This provides an alternative for usage when frrcfgd is not enabled. Some users may need to use it this way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrrcfgd is totally a duplicate code, I would like to better understand in which case vrrpcfgd will be enabled but not frrcfgd. Keeping both the code will be hard to manage, I would recommend using frrcfgd only for VRRP feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrrcfgd is totally a duplicate code, I would like to better understand in which case vrrpcfgd will be enabled but not frrcfgd. Keeping both the code will be hard to manage, I would recommend using frrcfgd only for VRRP feature.

OK, vrrpcfgd has been removed, thanks.

philo-micas and others added 3 commits September 10, 2024 16:02
…54-support-vrrp6-commands-and-tracking-interface.patch
Signed-off-by: philo <philo@micasnetworks.com>
@nmoray
Copy link
Contributor

nmoray commented Sep 27, 2024

@philo-micas As per the HLD, I am unable to find the changes related to vrrpsyncd and vrrporch in any of your PRs. Can you please point me to the respective PR?
cc: @venkatmahalingam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants