-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chassis][voq] Remove the leaf ref for the ifname in sonic-system-port.yang #18855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
requested review from
kenneth-arista,
xincunli-sonic and
qiluo-msft
and removed request for
qiluo-msft
May 2, 2024 21:33
kenneth-arista
approved these changes
May 3, 2024
xincunli-sonic
approved these changes
May 3, 2024
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
test |
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
added
the
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
label
May 8, 2024
matiAlfaro
reviewed
May 9, 2024
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
May 13, 2024
gechiang
added
the
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
label
Jun 5, 2024
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…t.yang (sonic-net#18855) Microsoft ADO 27934751: Fixes sonic-net#18854 Update the sonic-system-port.yang to remove the check to have ifname as leafref in the port table The system-port config table will have all the ports in the chassis not only to one linecard, so in case of the chassis with different linecards sku with different number of ports this leafref will not work.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
chassis-voq
Voq chassis changes
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
P0
Priority of the issue
YANG
YANG model related changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
Fixes #18854
Update the
sonic-system-port.yang
to remove the check to haveifname
as leafref in the port tableThe system-port config table will have all the ports in the chassis not only to one linecard, so in case of the chassis with different linecards sku with different number of ports this leafref will not work.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)