Reliable TSA implementation #18928
Merged
Reliable TSA implementation #18928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
|
@StormLiangMS / @lguohan Could you please restart the Azure pipeline? |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 18928 in repo sonic-net/sonic-buildimage |
|
/Azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
|
/Azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
reviewed
May 29, 2024
|
|
||
| if [[ -f /etc/sonic/chassisdb.conf ]]; then | ||
| tsa_cfg="$(sonic-db-cli CONFIG_DB HGET "BGP_DEVICE_GLOBAL|STATE" "tsa_enabled")" | ||
| sonic-db-cli CHASSIS_APP_DB HMSET "BGP_DEVICE_GLOBAL|STATE" tsa_enabled ${tsa_cfg} |
There was a problem hiding this comment.
is it ok to write APP_DB in this way ? Generally we use swssconfig to regular APP DB ?
There was a problem hiding this comment.
Yes, there is no concern, it is consistent with the existing approach. --There are several example in sonic-utilities, e.g.,
scripts/route_check_test.sh: sonic-db-cli -n asic0 APPL_DB hmset "ROUTE_TABLE:20c0:d9b8:99:80::/64" "nexthop" "fc00::72,fc00::76,fc00::7a,fc00::7e" "ifname" "PortChannel01,PortChannel02,PortChannel03,PortChannel04" > /dev/null
scripts/route_check_test.sh: sonic-db-cli -n asic0 ASIC_DB hmset "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:{\"dest\":\"192.193.120.255/25\",\"switch_id\":\"oid:0x21000000000000\",\"vr\":\"oid:0x3000000000022\"}" "SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID" "oid:0x5000000000614" > /dev/null
bingwang-ms
added a commit
that referenced
this pull request
Jun 2, 2024
This reverts commit 9d5fb20.
|
@fountzou I suspect the PR caused regression on Non-chassis platform. Can you please check? Thanks! |
yxieca
pushed a commit
that referenced
this pull request
Jun 3, 2024
11 tasks
8 tasks
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
* Reliable TSA implementation --------- Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
This reverts commit 9d5fb20.
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Implementing Reliable TSA feature as described in the HLD doc
Work item tracking
How I did it
A new attribute "tsa_enabled" has been added in CHASSIS_APP_DB the value of which changes whenever TSA/TSB is issued in the supervisor (default value is false). bgpcfgd subscribes to CHASSIS_APP_DB to receive updates on the newly added "tsa_enabled" attribute and in conjunction with the CONFIG_DB "tsa_enabled" attribute value, determine the BGP operational state is determined to be in TSA or TSB.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)