Fix LLDP netlink buffer size issue #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior could be that we are sending LLDP message but not using lldpcli configured properties if netlink delete messages were lost. It also could be that some interfaces do not sending messages at all. "lldpcli show statistics" could see duplicated or missing interfaces. Changes: Upgrade lldpd to 0.9.6 (which introduced the adjustable netlink buffer size) Change the netlink receive buffer size to 1MB
lguohan
approved these changes
Aug 10, 2018
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Sep 16, 2021
* c3691d3 [202012][pfcwd] Convert polling interval from ms to us in LUA scripts (sonic-net#1909) * 549c804 Mux state order change (sonic-net#1902) * 6b0b2c4 Update acl type check logic (sonic-net#1886) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
4 tasks
prsunny
pushed a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLDP is misbehaving if netlink messages were lost due to timing/buffer size issue.
The behavior could be that we are sending LLDP message but not using
lldpcli configured properties if netlink delete messages were lost.
It also could be that some interfaces do not sending messages at all.
"lldpcli show statistics" could see duplicated or missing interfaces.
Changes:
Upgrade lldpd to 0.9.6 (which introduced the adjustable netlink buffer size)
Change the netlink receive buffer size to 1MB
- What I did
Fix the llpd netlink buffer size issue
- How I did it
Upgrade lldp to 0.9.6
Increase the netlink receive buffer size to 1MB.
- How to verify it
Before fix, if I repeat doing "service swss restart", I could see the interfaces numbers from "lldpcli show statistics" sometimes do not match the expected one, it can be reproduced very often (one out of a few of times).
After fix, tried "service swss restart" 100+ times, no mismatch were noticed.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)