-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[baseimage]: simplify script to install docker #1925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
can you describe the issue of previous script? I do not understand why it has the issue. |
My guess is that 'bash -x' may not print logs at the exactly time point or may fail to print around an exit point. So the previous logs are not that reasonable. I am trying to tune the script into the most plain way, in hope to solve the issue. |
lguohan
changed the title
Simplify script to install docker
[baseimage]: simplify script to install docker
Aug 14, 2018
Pterosaur
added a commit
to Pterosaur/sonic-buildimage
that referenced
this pull request
Oct 26, 2021
7444e96 [macsecmgr]: Add rekey period in macsec mgr (sonic-net#1958) d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for Layer2 extension (sonic-net#1858) 85bdf54 Fix the option missing in kernel config issue (sonic-net#1973) 6b15584 (master) Orchagent validates mirror session queue parameter against maximum value from SAI (sonic-net#1957) fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925) f248e26 [orchagent] Add separate next hop table and orch (sonic-net#1702) fd0cafe [portorch]: Skip to create port if the lane set isn't available in ASIC (sonic-net#1923) ef6b5d4 fix the type for SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE (sonic-net#1942) b592ad7 [cfgmgr] Fix for STATE_DB Port check (sonic-net#1936) Signed-off-by: Ze Gan <ganze718@gmail.com>
5 tasks
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Oct 29, 2021
The submodule update includes the following commits ac3103a Add missing neighbor resolution for MPLS route programming (sonic-net#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980) 9ef2ba4 Update VLAN removal code to work with 5.10 kernel and new 41fb26c Handle setting unknown mux state (sonic-net#1984) ac09bde Increase timeout for VS tests (sonic-net#1988) da8a43e Check if appl DB exists before deleting (sonic-net#1983) 553d75a Change tunnel orch order (sonic-net#1977) 7444e96 Add rekey period in macsec mgr (sonic-net#1958) d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for L 85bdf54 Fix the option missing in kernel config issue (sonic-net#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum va fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925) Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
lguohan
pushed a commit
that referenced
this pull request
Nov 1, 2021
The submodule update includes the following commits ac3103a Add missing neighbor resolution for MPLS route programming (#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (#1980) 9ef2ba4 Update VLAN removal code to work with 5.10 kernel and new 41fb26c Handle setting unknown mux state (#1984) ac09bde Increase timeout for VS tests (#1988) da8a43e Check if appl DB exists before deleting (#1983) 553d75a Change tunnel orch order (#1977) 7444e96 Add rekey period in macsec mgr (#1958) d95823d [Buffermgr]Graceful handling of buffer model change (#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for L 85bdf54 Fix the option missing in kernel config issue (#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum va fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (#1925) Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Nov 11, 2021
``` 5f8ebfa (HEAD, origin/master, origin/HEAD, master) [AclOrch] move ACL counters to flex counter infrastructure (sonic-net#1943) 8119ec0 [bfdorch] Orchagent support hardware BFD (sonic-net#1883) 15074ac [sonic-swss]:enable unconfiguring PFC on last TC on a port (sonic-net#1962) 05c7c05 [Mux orch] set default as standby, change mux orch priority (sonic-net#2010) fe5b2a9 [pytest]: Ignore errors deleting host ifs (sonic-net#2005) 70da9af [ci]: use native arm64 and armhf pool (sonic-net#2013) e14a071 [qos] Add EXP to TC map support (sonic-net#1954) c91a7f2 [switchorch] Implement VXLAN src port range feature (sonic-net#1959) b20f0f4 Gcov for swss daemon (sonic-net#1737) 01c243a [CRM][MPLS] Fix the mpls nexthop CRM attribute (sonic-net#2008) 8448a60 [vs tests]Migrating sonic-swss tests to use hwsku instead of fakeplatform (sonic-net#1978) faa26db Fix random failure in PR/CI build. (sonic-net#2006) e03edb6 Allow interface type value none (sonic-net#1991) 71b9650 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (sonic-net#1967) facdef5 [VS test] Skip flaky virtual chassis test (sonic-net#2004) 8261c1f [pytest]: Increase timeout when checking services (sonic-net#2000) 67278be [teammgrd]: Handle LAGs cleanup gracefully on Warm/Fast reboot. (sonic-net#1934) e92c1df Enable FEC statistics collection for Ethernet ports (sonic-net#1994) 9f30ca1 VxLAN Tunnel Counters and Rates implementation (sonic-net#1859) ac3103a Add missing neighbor resolution for MPLS route programming (sonic-net#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980) 9ef2ba4 [vlanmgr]: Update VLAN removal code to work with 5.10 kernel and newer iproute2 versions (sonic-net#1970) 41fb26c [Mux orch] Handle setting unknown mux state (sonic-net#1984) ac09bde [azp]: Increase timeout for VS tests (sonic-net#1988) da8a43e [pytest]: Check if appl DB exists before deleting (sonic-net#1983) 553d75a [tunnel decap] Change tunnel orch order (sonic-net#1977) 7444e96 [macsecmgr]: Add rekey period in macsec mgr (sonic-net#1958) d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for Layer2 extension (sonic-net#1858) 85bdf54 Fix the option missing in kernel config issue (sonic-net#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum value from SAI (sonic-net#1957) fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Nov 23, 2021
a0bff26 [acl-loader] modify acl-loader with change in STATE DB ACL capability table (sonic-net#1896) a395e28 [debug dump util] Changes for EVPN and VxLAN dump module (sonic-net#1892) 02a98ef [debug dump util] Route Module added (sonic-net#1913) ac8382f [generic-config-updater] Logging change just before applying it (sonic-net#1934) 9ab6c51 [flex counter] Flex counter threads consume too much CPU resources. sonic-net#9202 (sonic-net#1925) 2ec47a5 [generic-config-updater] Handling empty tables while sorting a patch (sonic-net#1923) fdedcbf [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1926) e7535ae [sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool (sonic-net#1644) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
5 tasks
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 24, 2021
a0bff26 [acl-loader] modify acl-loader with change in STATE DB ACL capability table (#1896) a395e28 [debug dump util] Changes for EVPN and VxLAN dump module (#1892) 02a98ef [debug dump util] Route Module added (#1913) ac8382f [generic-config-updater] Logging change just before applying it (#1934) 9ab6c51 [flex counter] Flex counter threads consume too much CPU resources. #9202 (#1925) 2ec47a5 [generic-config-updater] Handling empty tables while sorting a patch (#1923) fdedcbf [fdbshow]: Handle FDB cleanup gracefully. (#1926) e7535ae [sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool (#1644) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
) * Add IPGadjusting for MACsec gearbox model Signed-off-by: Ze Gan <ganze718@gmail.com> * fix bug Signed-off-by: Ze Gan <ganze718@gmail.com> * fix bug Signed-off-by: Ze Gan <ganze718@gmail.com> * Polish variable name and comment Signed-off-by: Ze Gan <ganze718@gmail.com> * Set IPG to optional Signed-off-by: Ze Gan <ganze718@gmail.com> * refactor code Signed-off-by: Ze Gan <ganze718@gmail.com>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…onic-net#9202 (sonic-net#1925) * [flex counter] Flex counter threads consume too much CPU resources. sonic-net#9202 Increase the interval up lmit from 30 seconds to 60 seconds * only modify the interval of watermark counter group * fix merge conflict * fix commit issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1924