Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inventec d6254qs d6556 platform suport and status led, sensors supports for all Inventec platform #1931

Closed
wants to merge 3 commits into from

Conversation

klhaung
Copy link
Contributor

@klhaung klhaung commented Aug 15, 2018

[device][platform] d6254qs d6556 platform
[platform] status led, sensors on d6254qs 6556 d7032q28b d7054q28b d7264q28b

- What I did

  • Add Inventec D6254QS,D6556 platform support
  • Add status led, sensors support for all inventec platform (D6254QS, D6556, D7032Q28B, D7054Q28B, D7264Q28B)
  • Bug fix in transceiver_monitor.py

- How I did it

  • Follow Porting Guide to port D6254QS,D6556
  • Follow Porting Guide to configure sensors.conf for all inventec platform (D6254QS, D6556, D7032Q28B, D7054Q28B, D7264Q28B)
  • Add drivers and python scripts for monitoring system status and doing the corresponding actions for all inventec platform ((D6254QS, D6556, D7032Q28B, D7054Q28B, D7264Q28B))
  • Add one more transceiver in transceiver_monitor.py

- How to verify it

  • Build image, install on device platform to make sure it is worked properly.

- Description for the changelog

  • Add Inventec D6254QS,D6556 platform support
  • Add status led, sensors supports for all Inventec platform (D6254QS, D6556, D7032Q28B, D7054Q28B, D7264Q28B)

- A picture of a cute animal (not mandatory but encouraged)

[platform] status led, sensors on d6254qs 6556 d7032q28b d7054q28b d7264q28b]
@klhaung klhaung closed this Aug 15, 2018
@klhaung klhaung reopened this Aug 15, 2018
@klhaung klhaung closed this Aug 15, 2018
@klhaung klhaung reopened this Aug 15, 2018
@klhaung klhaung changed the title [device][platform] d6254qs d6556 d7264 platform suport Add Inventec d6254qs d6556 d7264 platform suport Aug 15, 2018
…nt,pdma_dv_free_size,pdma_descriptor_prefetech_enable,port_flex_enable in permitted_list for TD3 support
@klhaung klhaung closed this Aug 15, 2018
@klhaung klhaung reopened this Aug 15, 2018
@klhaung klhaung closed this Aug 15, 2018
@klhaung klhaung reopened this Aug 15, 2018
@klhaung klhaung changed the title Add Inventec d6254qs d6556 d7264 platform suport Add Inventec d6254qs d6556 platform suport Aug 15, 2018
@klhaung klhaung changed the title Add Inventec d6254qs d6556 platform suport Add Inventec d6254qs d6556 platform suport and status led, sensors supports for all Inventec platform Aug 15, 2018
@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2018

port_flex_enable

not all attributes in
this list.

http://broadcom-switch.github.io/OpenNSL/doc/html/OPENNSL_CUSTOMIZING_OPENNSL.html


Refers to: src/sonic-device-data/tests/permitted_list:142 in c131457. [](commit_id = c131457, deletion_comment = False)

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2018

build break for broadcom platform.

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2018

what are bcm56870_a0_cmh.pkg those files, zero bytes? Please remove.


pdma_dv_free_count=64
pdma_dv_free_size=320
pdma_descriptor_prefetch_enable=1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need these pdma settings?

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2018

thread_st = kthread_run(thread_fn, (void*)&thread_data, "inv_pthread");

what does this kernel thread do? why not move into user space?


Refers to: platform/broadcom/sonic-platform-modules-inventec/d7032q28b/modules/inv_pthread.c:1269 in c131457. [](commit_id = c131457, deletion_comment = False)

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2018

  • lpc_ich.c - LPC interface for Intel ICH

4.9 kernel has this file, please reuse the module in the kernel. if you need to modify, please patch the kernel.


Refers to: platform/broadcom/sonic-platform-modules-inventec/d6556/modules/lpc_ich.c:2 in c131457. [](commit_id = c131457, deletion_comment = False)

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2018

please add license for every file. all kernel module file should be gplv2, all other files should be apache license.

@klhaung
Copy link
Contributor Author

klhaung commented Aug 16, 2018

#1 For build break for broadcom platform:
From console log, look like it broke becasue of kernel change from 3.16 to 4.9. We will check how to make it compiled on kernel 4.9.

#2 For lpc_ich.c
We did all these fixes before 7/E and kernel 3.6 doesn't have this module by default. We will study how to port new platform again on kernel 4.9

#3 What does this kernel thread do
use to check psu modules and fan modules and send uevent to notify user-space application for doing corresponding actions. It is better to do them in driver in case the user-space application is stopped by some unknown reason.

#4 why do you need these pdma settings?

We follows Broadcom's suggestion to configure TD3. The example bcm files are config_td3_128x25G_pwr.bcm and config_td3_tr514_os.bcm, not quite understand what they are used for from application point of view.

#5 not all attributes in this list.

Good point. Look like Broadcom doesn't announce all the attributes for TD3 yet. Without these three attributes, cancun_dir, led_fw_dir, ifp_inports_support_enable, we cannot bring up SONiC on TD3 successfully. Without the other three attributes, we got warning messages when syncd bring up.

@klhaung
Copy link
Contributor Author

klhaung commented Aug 16, 2018

Close this PR becaus the fixes we did was done and verified on kernel 3.6.

@klhaung klhaung closed this Aug 16, 2018
prsunny added a commit that referenced this pull request Sep 27, 2021
*ee9c30d - 2021-09-24 : [202012] Cache route for single nexthop for faster retrieval (#1931) [Prince Sunny]
*84f1c63 - 2021-09-24 : [lgtm] Fix LGTM build on 202012 branch (#1921) [Kamil Cudnik]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants