-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inventec d6254qs d6556 platform suport and status led, sensors supports for all Inventec platform #1931
Conversation
[platform] status led, sensors on d6254qs 6556 d7032q28b d7054q28b d7264q28b]
…nt,pdma_dv_free_size,pdma_descriptor_prefetech_enable,port_flex_enable in permitted_list for TD3 support
not all attributes in http://broadcom-switch.github.io/OpenNSL/doc/html/OPENNSL_CUSTOMIZING_OPENNSL.html Refers to: src/sonic-device-data/tests/permitted_list:142 in c131457. [](commit_id = c131457, deletion_comment = False) |
build break for broadcom platform. |
what are bcm56870_a0_cmh.pkg those files, zero bytes? Please remove. |
|
||
pdma_dv_free_count=64 | ||
pdma_dv_free_size=320 | ||
pdma_descriptor_prefetch_enable=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need these pdma settings?
4.9 kernel has this file, please reuse the module in the kernel. if you need to modify, please patch the kernel. Refers to: platform/broadcom/sonic-platform-modules-inventec/d6556/modules/lpc_ich.c:2 in c131457. [](commit_id = c131457, deletion_comment = False) |
please add license for every file. all kernel module file should be gplv2, all other files should be apache license. |
#1 For build break for broadcom platform: #2 For lpc_ich.c #3 What does this kernel thread do #4 why do you need these pdma settings? We follows Broadcom's suggestion to configure TD3. The example bcm files are config_td3_128x25G_pwr.bcm and config_td3_tr514_os.bcm, not quite understand what they are used for from application point of view. #5 not all attributes in this list. Good point. Look like Broadcom doesn't announce all the attributes for TD3 yet. Without these three attributes, cancun_dir, led_fw_dir, ifp_inports_support_enable, we cannot bring up SONiC on TD3 successfully. Without the other three attributes, we got warning messages when syncd bring up. |
Close this PR becaus the fixes we did was done and verified on kernel 3.6. |
[device][platform] d6254qs d6556 platform
[platform] status led, sensors on d6254qs 6556 d7032q28b d7054q28b d7264q28b
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)