Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YANG] Update device_metadata to add suppress-fib-pending field #19329

Merged

Conversation

Gfrom2016
Copy link
Contributor

@Gfrom2016 Gfrom2016 commented Jun 17, 2024

Why I did it

BGP pending FIB suppression is introduced in #12853, hence updating the YANG model.

Work item tracking
  • Microsoft ADO (number only): 28398135

How I did it

Added a new field 'suppress-fib-pending' in the DEVICE_METADATA YANG model table.
Added UT for YANG model changes.

How to verify it

Run PR tests.
Apply empty.json file to verify:

admin@str2-7050cx3-acs-02:~$ sudo config apply-patch empty.json 
Patch Applier: Patch application starting.
Patch Applier: Patch: []
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
Patch Applier: Validating all JsonPatch operations are permitted on the specified fields
Patch Applier: Validating target config does not have empty tables, since they do not show up in ConfigDb.
Patch Applier: Sorting patch updates.
Patch Applier: The patch was converted into 0 changes.
Patch Applier: Applying 0 changes in order.
Patch Applier: Verifying patch updates are reflected on ConfigDB.
Patch Applier: Patch application completed.
Patch applied successfully.
admin@str2-7050cx3-acs-02:~$ 

Signed-off-by: zitingguo-ms zitingguo@microsoft.com

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
@Gfrom2016 Gfrom2016 changed the title [test only]add suppress-fib-pending field in yang [YANG] Update device_metadata to add suppress-fib-pending field Jun 18, 2024
@Gfrom2016 Gfrom2016 marked this pull request as ready for review June 19, 2024 11:47
Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS requested a review from wen587 June 19, 2024 14:17
Copy link
Contributor

@yutongzhang-microsoft yutongzhang-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gfrom2016
Copy link
Contributor Author

@wen587 Could you help to review this?

Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 8fb3fde into sonic-net:202311 Jun 20, 2024
18 checks passed
@Gfrom2016 Gfrom2016 deleted the add_mssing_fib_field_in_yang_202311 branch September 2, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants