Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Route map for BGP profile FROM_SDN_APPLIANCE_ROUTES #19871

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

siqbal1986
Copy link
Contributor

@siqbal1986 siqbal1986 commented Aug 9, 2024

Why I did it

This is a bug fix and this change should go into 202305 brranch and onwards.
Added Route map support for BGP profile FROM_SDN_APPLIANCE_ROUTES
With this change the following route map should be added if the BGP profile is added

route-map FROM_SDN_APPLIANCE_ROUTES_RM permit 100
set as-path prepend <Prepend value of FROM_SDN_SLB_DEPLOYMENT_ID>
set community <community id>
set origin incomplete
Work item tracking
  • Microsoft ADO (number only):
    28896695

How I did it

How to verify it

Added test to verify the rotue map creation.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

NO yang changes required.

A picture of a cute animal (not mandatory but encouraged)

@siqbal1986 siqbal1986 changed the title [Bug Fix] Route map for BGP profile FROM_COM_SDN_APPLIENCE_ROUTES [Bug Fix] Route map for BGP profile FROM_SDN_APPLIANCE_ROUTES Aug 20, 2024
@siqbal1986
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siqbal1986
Copy link
Contributor Author

@StormLiangMS can you please get this merged

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor question.

What does this set origin incomplete mean?

@siqbal1986
Copy link
Contributor Author

Set origin incomplete tells the that this route was not learned via any protocol and it was directly injected

@StormLiangMS StormLiangMS merged commit 5ac82b5 into sonic-net:master Aug 30, 2024
23 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 31, 2024
…net#19871)

Why I did it
This is a bug fix and this change should go into 202305 brranch and onwards.
Added Route map support for BGP profile FROM_SDN_APPLIANCE_ROUTES
With this change the following route map should be added if the BGP profile is added

route-map FROM_SDN_APPLIANCE_ROUTES_RM permit 100
set as-path prepend <Prepend value of FROM_SDN_SLB_DEPLOYMENT_ID>
set community <community id>
set origin incomplete
Work item tracking
Microsoft ADO (number only):
28896695
How I did it
How to verify it
Added test to verify the rotue map creation.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20097

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 31, 2024
…net#19871)

Why I did it
This is a bug fix and this change should go into 202305 brranch and onwards.
Added Route map support for BGP profile FROM_SDN_APPLIANCE_ROUTES
With this change the following route map should be added if the BGP profile is added

route-map FROM_SDN_APPLIANCE_ROUTES_RM permit 100
set as-path prepend <Prepend value of FROM_SDN_SLB_DEPLOYMENT_ID>
set community <community id>
set origin incomplete
Work item tracking
Microsoft ADO (number only):
28896695
How I did it
How to verify it
Added test to verify the rotue map creation.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #20098

mssonicbld pushed a commit that referenced this pull request Sep 1, 2024
Why I did it
This is a bug fix and this change should go into 202305 brranch and onwards.
Added Route map support for BGP profile FROM_SDN_APPLIANCE_ROUTES
With this change the following route map should be added if the BGP profile is added

route-map FROM_SDN_APPLIANCE_ROUTES_RM permit 100
set as-path prepend <Prepend value of FROM_SDN_SLB_DEPLOYMENT_ID>
set community <community id>
set origin incomplete
Work item tracking
Microsoft ADO (number only):
28896695
How I did it
How to verify it
Added test to verify the rotue map creation.
mssonicbld pushed a commit that referenced this pull request Sep 1, 2024
Why I did it
This is a bug fix and this change should go into 202305 brranch and onwards.
Added Route map support for BGP profile FROM_SDN_APPLIANCE_ROUTES
With this change the following route map should be added if the BGP profile is added

route-map FROM_SDN_APPLIANCE_ROUTES_RM permit 100
set as-path prepend <Prepend value of FROM_SDN_SLB_DEPLOYMENT_ID>
set community <community id>
set origin incomplete
Work item tracking
Microsoft ADO (number only):
28896695
How I did it
How to verify it
Added test to verify the rotue map creation.
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024
…net#19871)

Why I did it
This is a bug fix and this change should go into 202305 brranch and onwards.
Added Route map support for BGP profile FROM_SDN_APPLIANCE_ROUTES
With this change the following route map should be added if the BGP profile is added

route-map FROM_SDN_APPLIANCE_ROUTES_RM permit 100
set as-path prepend <Prepend value of FROM_SDN_SLB_DEPLOYMENT_ID>
set community <community id>
set origin incomplete
Work item tracking
Microsoft ADO (number only):
28896695
How I did it
How to verify it
Added test to verify the rotue map creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants