Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista]: Change the TH5 Yaml settings to use 8 UC and 4 MC queues #19912

Merged
merged 3 commits into from
Nov 19, 2024
+6 −40
Merged

[Arista]: Change the TH5 Yaml settings to use 8 UC and 4 MC queues #19912

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8800b5
Change the Yaml settings to use 8 UC and 4 MC queues, as SONIC only u…
Pterosaur Aug 15, 2024
61081e8
Revert useless change
Pterosaur Oct 29, 2024
d40b56d
fix comments
Pterosaur Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .../arista/x86_64-arista_7060x6_64pe/Arista-7060X6-64PE-256x200G/th5-a7060x6-64pe.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,7 +1947,7 @@ device:
THRESHOLD_MODE: LOSSY_AND_LOSSLESS

TM_SCHEDULER_CONFIG:
NUM_MC_Q: NUM_MC_Q_2
NUM_MC_Q: NUM_MC_Q_4

...

Expand Down Expand Up @@ -2144,7 +2144,7 @@ device:
TM_PORT_MC_Q_TO_SERVICE_POOL:
?
PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351]
TM_MC_Q_ID: [[0,1]]
TM_MC_Q_ID: [[0,3]]
:
USE_QGROUP_MIN: 0

Expand All @@ -2161,7 +2161,7 @@ device:
?
# uplink, downlink and loopback ports, 2 MC queues
PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351]
TM_MC_Q_ID: [[0,1]]
TM_MC_Q_ID: [[0,3]]
:
MIN_GUARANTEE_CELLS: 0
SHARED_LIMITS: 1
Expand Down Expand Up @@ -2622,7 +2622,7 @@ device:
TM_PORT_UC_Q_TO_SERVICE_POOL:
?
PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351]
TM_UC_Q_ID: [0,1,2,5,6,8,9]
TM_UC_Q_ID: [0,1,2,5,6]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when searching the BCM file, I am still seeing some UC Q settings on queue 8 and 9. they are removed in the first commit, but somehow removed in the second one:

E.g.:

                PORT_ID: [[1,8], [11,18], [22,29], [33,40], [44,51], [55,62], [66,73], [77,84], [88,95], [99,106], [110,117], [121,128], [132,139], [143,150], [154,161], [165,172]]
                TM_UC_Q_ID: [8,9]
            :
                MIN_GUARANTEE_CELLS: 0
                SHARED_LIMITS: 1
                DYNAMIC_SHARED_LIMITS: 1
                SHARED_LIMIT_CELLS_STATIC: 0
                SHARED_LIMIT_DYNAMIC: ALPHA_1
                DYNAMIC_GROUP: MID_PRI_GROUP
                RESUME_OFFSET_CELLS: 2
                COLOR_SPECIFIC_LIMITS: 0
                COLOR_SPECIFIC_DYNAMIC_LIMITS: 0
                YELLOW_LIMIT_CELLS_STATIC: 0
                YELLOW_LIMIT_DYNAMIC: PERCENTAGE_750
                RED_LIMIT_CELLS_STATIC: 0
                RED_LIMIT_DYNAMIC: PERCENTAGE_625
            ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to remove this block as well -

sonic-buildimage/device/arista/x86_64-arista_7060x6_64pe/Arista-7060X6-64PE-256x200G/th5-a7060x6-64pe.config.bcm

Lines 2728 to 2743 in 61081e8

PORT_ID: [[176,183], [187,194], [198,205], [209,216], [220,227], [231,238], [242,249], [253,260], [264,271], [275,282], [286,293], [297,304], [308,315], [319,326], [330,337], [341,348]]
TM_UC_Q_ID: [8,9]
:
MIN_GUARANTEE_CELLS: 0
SHARED_LIMITS: 1
DYNAMIC_SHARED_LIMITS: 1
SHARED_LIMIT_CELLS_STATIC: 0
SHARED_LIMIT_DYNAMIC: ALPHA_1
DYNAMIC_GROUP: MID_PRI_GROUP
RESUME_OFFSET_CELLS: 2
COLOR_SPECIFIC_LIMITS: 0
COLOR_SPECIFIC_DYNAMIC_LIMITS: 0
YELLOW_LIMIT_CELLS_STATIC: 0
YELLOW_LIMIT_DYNAMIC: PERCENTAGE_750
RED_LIMIT_CELLS_STATIC: 0
RED_LIMIT_DYNAMIC: PERCENTAGE_625

:
USE_QGROUP_MIN: 0
TM_EGR_SERVICE_POOL_ID: 0
Expand All @@ -2648,7 +2648,7 @@ device:
TM_EGR_SERVICE_POOL_ID: 1
?
PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351]
TM_MC_Q_ID: [[0,1]]
TM_MC_Q_ID: [[0,3]]
:
USE_QGROUP_MIN: 0
TM_EGR_SERVICE_POOL_ID: 0
Expand Down Expand Up @@ -2778,7 +2778,7 @@ device:
RESUME_OFFSET_CELLS: 2
?
PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351]
TM_MC_Q_ID: [0,1]
TM_MC_Q_ID: [0,3]
SHARED_LIMIT_DYNAMIC: ALPHA_2
:
SHARED_LIMITS: 1
Expand Down
Loading