Add sensor packages to syncd for bfn #1997
Conversation
|
why the sensors and fancontrol packages are installed in the syncd container? |
| @@ -27,6 +27,8 @@ RUN apt-get update \ | |||
| python-dev \ | |||
| wget \ | |||
| cmake \ | |||
| sensord \ | |||
| fancontrol \ | |||
There was a problem hiding this comment.
sensord and fancontrol are already in pmon docker, why do we need them in syncd docker?
There was a problem hiding this comment.
For bfn platforms, sensors information is not available on the host cpu and is fetched from the BMC. The infra needed to retrieve this information is available present in the syncd container, which we leverage for retrieving needed information from the BMC. Hence the need to have these packages in syncd
There was a problem hiding this comment.
can you pass the information from syncd to the pmon docker? we'd like to unify the those controller in one place for all platforms.
There was a problem hiding this comment.
That would need us to install all python libraries on pmon container along with some rpc infra to communicate with syncd container. I do not know of any other clean mechanism to pass data between two containers. Hence the need to have these packages on syncd itself
|
could you resolve the conflicts? |
|
@lguohan - what else do we need to do here? |
Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>
- What I did
Added sensor packages to bfn syncd container
- How I did it
Added packages to install to Docker files
- How to verify it
Build sonic binary and verify sensor utility present inside syncd container
- Description for the changelog
Add linux sensor utility to syncd for bfn
- A picture of a cute animal (not mandatory but encouraged)