Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform/dx010] Fix issing qsfp_reset sysfs file #2007

Merged
merged 2 commits into from
Sep 5, 2018
Merged

[platform/dx010] Fix issing qsfp_reset sysfs file #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4444148
Fix qsfp_reset file missing.
pphuchar Aug 30, 2018
1e7d781
[platform/dx010] Add systemd unit for platform init.
pphuchar Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-dx010.init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ case "$1" in
start)
echo -n "Setting up board... "

depmod -a
modprobe i2c-dev
modprobe i2c-mux-pca954x
modprobe dx010_wdt
Expand Down
1 change: 1 addition & 0 deletions platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-dx010.install
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
dx010/scripts/dx010_check_qsfp.sh usr/local/bin
dx010/cfg/dx010-modules.conf etc/modules-load.d
dx010/systemd/platform-modules-dx010.service lib/systemd/system
3 changes: 3 additions & 0 deletions platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-dx010.postinst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
depmod -a
systemctl enable platform-modules-dx010.service
systemctl start platform-modules-dx010.service
59 changes: 57 additions & 2 deletions platform/broadcom/sonic-platform-modules-cel/dx010/modules/dx010_cpld.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@

#define DRIVER_NAME "dx010_cpld"

#define RESET0108 0x250
#define RESET0910 0x251
#define RESET1118 0x2d0
#define RESET1921 0x2d1
#define RESET2229 0x3d0
#define RESET3032 0x3d1

#define LPMOD0108 0x252
#define LPMOD0910 0x253
#define LPMOD1118 0x2d2
Expand All @@ -51,6 +58,7 @@
#define INT2229 0x3d6
#define INT3032 0x3d7


#define LENGTH_PORT_CPLD 34
#define PORT_BANK1_START 1
#define PORT_BANK1_END 10
Expand Down Expand Up @@ -106,6 +114,53 @@ struct dx010_cpld_data {

struct dx010_cpld_data *cpld_data;

static ssize_t get_reset(struct device *dev, struct device_attribute *devattr,
char *buf)
{
unsigned long reset = 0;

mutex_lock(&cpld_data->cpld_lock);

reset =
(inb(RESET3032) & 0x07) << (24+5) |
inb(RESET2229) << (24-3) |
(inb(RESET1921) & 0x07) << (16 + 2) |
inb(RESET1118) << (16-6) |
(inb(RESET0910) & 0x03 ) << 8 |
inb(RESET0108);

mutex_unlock(&cpld_data->cpld_lock);

return sprintf(buf,"0x%8.8lx\n", reset & 0xffffffff);
}

static ssize_t set_reset(struct device *dev, struct device_attribute *devattr,
const char *buf, size_t count)
{
unsigned long reset;
int err;

mutex_lock(&cpld_data->cpld_lock);

err = kstrtoul(buf, 16, &reset);
if (err)
{
mutex_unlock(&cpld_data->cpld_lock);
return err;
}

outb( (reset >> 0) & 0xFF, RESET0108);
outb( (reset >> 8) & 0x03, RESET0910);
outb( (reset >> 10) & 0xFF, RESET1118);
outb( (reset >> 18) & 0x07, RESET1921);
outb( (reset >> 21) & 0xFF, RESET2229);
outb( (reset >> 29) & 0x07, RESET3032);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it is better to check if it is zero or not, if none of the pin is put into reset mode, then you should not write to the register.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total 32 pins, what about the sfp port?


mutex_unlock(&cpld_data->cpld_lock);

return count;
}

static ssize_t get_lpmode(struct device *dev, struct device_attribute *devattr,
char *buf)
{
Expand Down Expand Up @@ -193,11 +248,13 @@ static ssize_t get_modirq(struct device *dev, struct device_attribute *devattr,
return sprintf(buf,"0x%8.8lx\n", irq & 0xffffffff);
}

static DEVICE_ATTR(qsfp_reset, S_IRUGO | S_IWUSR, get_reset, set_reset);
static DEVICE_ATTR(qsfp_lpmode, S_IRUGO | S_IWUSR, get_lpmode, set_lpmode);
static DEVICE_ATTR(qsfp_modprs, S_IRUGO, get_modprs, NULL);
static DEVICE_ATTR(qsfp_modirq, S_IRUGO, get_modirq, NULL);

static struct attribute *dx010_lpc_attrs[] = {
&dev_attr_qsfp_reset.attr,
&dev_attr_qsfp_lpmode.attr,
&dev_attr_qsfp_modprs.attr,
&dev_attr_qsfp_modirq.attr,
Expand Down Expand Up @@ -247,7 +304,6 @@ static int i2c_read_eeprom(struct i2c_adapter *a, u16 addr,
short temp;
short portid, opcode, devaddr, cmdbyte0, ssrr, writedata, readdata;
__u16 word_data;
char read_byte;
int error = -EIO;

mutex_lock(&cpld_data->cpld_lock);
Expand Down Expand Up @@ -465,7 +521,6 @@ static int cel_dx010_lpc_drv_probe(struct platform_device *pdev)
static int cel_dx010_lpc_drv_remove(struct platform_device *pdev)
{
int portid_count;
struct dx010_i2c_data *new_data;

sysfs_remove_group(&pdev->dev.kobj, &dx010_lpc_attr_grp);

Expand Down
14 changes: 14 additions & 0 deletions platform/broadcom/sonic-platform-modules-cel/dx010/systemd/platform-modules-dx010.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@

[Unit]
Description=Celestica Seastone dx010 platform modules
After=local-fs.target
Before=pmon.service

[Service]
Type=oneshot
ExecStart=-/etc/init.d/platform-modules-dx010 start
ExecStop=-/etc/init.d/platform-modules-dx010 stop
RemainAfterExit=yes

[Install]
WantedBy=multi-user.target