Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S5248F: Dynamic port breakout support #20287

Merged

Conversation

arunlk-dell
Copy link
Contributor

@arunlk-dell arunlk-dell commented Sep 18, 2024

Why I did it

Added Dynamic port breakout support for S5248F DellEMC platform

How I did it

Modified the default hwsku profile for DPB support and updated the platform.json file with breakout options.

How to verify it

Unit_Testlog.txt

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

DellEMC-S5248f-P-25G-DPB t1
Copy link
Contributor

@srideepDell srideepDell Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunlk-dell with change it will defaults to DPB sku. does it still bootup successfully with out breakout ? Add logs for successful boot up without breakout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will bootup successfully with default breakouts as per port_config.ini and hwsku.json values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srideepDell instead of adding new sku, added the DPB support to the existing sku.

@jeff-yin
Copy link
Collaborator

This PR fixes issue #19995

@lguohan lguohan merged commit 456671c into sonic-net:master Oct 5, 2024
23 checks passed
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Oct 9, 2024
Added Dynamic port breakout support for S5248F DellEMC platform

How I did it
Modified the default hwsku profile for DPB support and updated the platform.json file with breakout options.
sschlafman pushed a commit to sschlafman/sonic-buildimage that referenced this pull request Oct 15, 2024
Added Dynamic port breakout support for S5248F DellEMC platform

How I did it
Modified the default hwsku profile for DPB support and updated the platform.json file with breakout options.
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
Added Dynamic port breakout support for S5248F DellEMC platform

How I did it
Modified the default hwsku profile for DPB support and updated the platform.json file with breakout options.
bradh352 pushed a commit to bradh352/sonic-buildimage that referenced this pull request Nov 18, 2024
Added Dynamic port breakout support for S5248F DellEMC platform

How I did it
Modified the default hwsku profile for DPB support and updated the platform.json file with breakout options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants