-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syslog] Add default syslog ip to interfaces.j2 #20340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azpw ms_conflict |
liuh-80
reviewed
Sep 25, 2024
liuh-80
approved these changes
Sep 25, 2024
/azpw ms_conflict |
/azpw run azure.sonic-buildimage |
/AzurePipelines run azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw ms_conflict |
/azpw ms_conflict |
/azpw run azure.sonic-buildimage |
/AzurePipelines run azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
maipbui
approved these changes
Oct 24, 2024
qiluo-msft
approved these changes
Oct 25, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 6, 2024
#### Why I did it This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided #### How I did it Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing #### How to verify it use j2 tempalte unit test
Cherry-pick PR to 202405: #20720 |
rkavitha-hcl
pushed a commit
to rkavitha-hcl/sonic-buildimage
that referenced
this pull request
Nov 15, 2024
#### Why I did it This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided #### How I did it Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing #### How to verify it use j2 tempalte unit test
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
#### Why I did it This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided #### How I did it Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing #### How to verify it use j2 tempalte unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided
Work item tracking
How I did it
Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing
How to verify it
use j2 tempalte unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)