Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syslog] Add default syslog ip to interfaces.j2 #20340

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Sep 24, 2024

Why I did it

This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided

Work item tracking
  • Microsoft ADO (number only):29270266

How I did it

Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing

How to verify it

use j2 tempalte unit test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@wen587
Copy link
Contributor Author

wen587 commented Sep 24, 2024

/azpw ms_conflict

@wen587
Copy link
Contributor Author

wen587 commented Sep 27, 2024

/azpw ms_conflict

@wen587
Copy link
Contributor Author

wen587 commented Oct 23, 2024

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Contributor Author

wen587 commented Oct 23, 2024

/azpw ms_conflict

@wen587
Copy link
Contributor Author

wen587 commented Oct 23, 2024

/azpw ms_conflict

@wen587
Copy link
Contributor Author

wen587 commented Oct 23, 2024

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587 wen587 marked this pull request as ready for review October 24, 2024 02:31
@wen587 wen587 requested a review from lguohan as a code owner October 24, 2024 02:31
@qiluo-msft qiluo-msft merged commit 4e9c08a into sonic-net:master Oct 25, 2024
22 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 6, 2024
#### Why I did it
This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided
#### How I did it
Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing
#### How to verify it
use j2 tempalte unit test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20720

rkavitha-hcl pushed a commit to rkavitha-hcl/sonic-buildimage that referenced this pull request Nov 15, 2024
#### Why I did it
This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided
#### How I did it
Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing
#### How to verify it
use j2 tempalte unit test
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
#### Why I did it
This is to make interfaces iprule to align with syslog server ip if exists and goes default if not provided
#### How I did it
Set ip rule when interface up and down. Fix test gap on interfaces.j2 for syslog parsing
#### How to verify it
use j2 tempalte unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants