sonic-buildimage: rename qsp 128x400g to o128s2, fix lane map typo #20580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In keeping with normative convention, renaming the hwsku folders for qsp/qspr from 128x400G to O128S2.
r12f
approved these changes
Oct 24, 2024
|
hi Chris - just in case, do you mind to mention this PR in the issue tracker? Storm will help check and get it merged. |
There is a typo in the lanes used for Ethernet356 within port_config.ini, where lanes 381 and 382 appear twice instead of being followed by the intended 383 and 384. This change fixes that typo. This exact typo is not present in the other hwskus under x86_64-arista_7060x6_64pe or x86_64-arista_7060x6_64de.
ccroy-arista
changed the title
|
@r12f FYI I expanded the scope of this PR a bit to include a commit to fix a small typo in the bcm config file (rather than having to wait for this PR to merge before posting a separate PR). |
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
|
hi @bingwang-ms could you help to cherry pick for 202405? This is for TH5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Renamed hwsku directory for qsp-128x400g in an effort to use consistent hwsku naming convention going forward.
Added fix for lane mapping typo found recently.
Work item tracking
How I did it
Renamed hwsku directory from
Arista-7060X6-64PE-128x400GtoArista-7060X6-64PE-O128S2.Changed lanes to correct mapping for Ethernet356.
How to verify it
Confirm that the "hwsku" entry in config_db.json: matches: "Arista-7060X6-64PE-O128S2"
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202405
Description for the changelog
Renaming a hwsku folder for qsp platform from 128x400G to O128S2. Fixing lane map typo for interface Ethernet356.