[FRR Patch] Added patch in FRR to send tag value associated with route via Netlink to fpmsyncd #20692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@StormLiangMS for viz |
dgsudharsan
reviewed
Nov 5, 2024
| ri->rtm_type = RTN_UNICAST; | ||
| - ri->metric = &re->metric; | ||
| + // Patch to send tag value via NETLINK Priority field (RTA_PRIORITY). The Tag vale can be used as metadata/attribute in fpmsyncd for further processing | ||
| + ri->metric = &re->tag; |
There was a problem hiding this comment.
Given now we migrated to dplane_fpm_sonic, does it require any changes over there?
dgsudharsan
reviewed
Nov 5, 2024
|
|
||
| ri->rtm_protocol = netlink_proto_from_route_type(re->type); | ||
| ri->rtm_type = RTN_UNICAST; | ||
| - ri->metric = &re->metric; |
There was a problem hiding this comment.
We are overriding the current meaning of metric by default. Would it impact any existing usecases/ scenarios?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added patch in FRR to send tag value associated with route via NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases.
Why I did:
Some of use cases:
How I verify:
Manual Verification.