[ipinip config] Add v6 ip and peering ip besides currect v4 loopback #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cfg gen unit test? #Resolved |
prsunny
reviewed
Oct 12, 2018
| {% endfor %} | ||
| [ | ||
| {% if ipv6_loopback_addresses %} |
There was a problem hiding this comment.
if ipv4_loopback_addresses? #Resolved
| "OP": "SET" | ||
| } | ||
| {% endif %} | ||
| {% if ipv4_loopback_addresses and ipv6_loopback_addresses %} , |
There was a problem hiding this comment.
Why do we need this check? #Resolved
There was a problem hiding this comment.
Because the comma is only needed when both v4 and v6 tunnel needs to be constructed. #Closed
|
Test fixed. #Closed |
prsunny
approved these changes
Oct 13, 2018
5 tasks
Ndancejic
pushed a commit
to Ndancejic/sonic-buildimage
that referenced
this pull request
May 3, 2022
*Increase test timout to 360 min
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 25, 2022
Update sonic-utilities submodule pointer to include the following: * [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171)) * [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118)) * [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153)) * show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851)) * [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174)) * Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176)) * [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l)) * Broadcast Unknown-multicast and Unknown-unicast Storm-control ([sonic-net#928](sonic-net/sonic-utilities#928)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151)) * Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165)) * [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145)) * [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116)) * support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167)) * [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150)) * [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157)) * Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162)) Signed-off-by: dprital <drorp@nvidia.com>
6 tasks
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 27, 2022
``` 3d3c89b fix for non-coherent cmis modules (sonic-net#2163) 2054680 [subinterface] Fix route add command to accept subinterface as dev (sonic-net#2180) 5383e92 [subinterface]Avoid removing the subinterface when last configured ip is removed (sonic-net#2181) f5af780 [GCU] Handling type1 lists (sonic-net#2171) 4516179 [yang] extend ConfigMgmt constructor to pass YANG options (sonic-net#2118) 2f53bd4 [dump] implement ACL modules (sonic-net#2153) 494dd62 show commands for SYSTEM READY (sonic-net#1851) 4fc09b1 [GCU] Handling non-compliant leaf-list with string values (sonic-net#2174) 675c7b6 Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) c587933 [portconfig] Allow to configure interface mtu for physical ports only 9881f3e Broadcast Unknown-multicast and Unknown-unicast Storm-control (sonic-net#928) 88286cb sonic-utils: initial support for link-training (sonic-net#2071) 29503ab [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel (sonic-net#2151) ac89489 Modify override testcase to cover PORT admin_status (sonic-net#2165) d7953d2 [GCU] Validate peer_group_range ip_range are correct (sonic-net#2145) aa81b97 [auto-ts] add memory check (sonic-net#2116) b370290 support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 (sonic-net#2167) 87fc0a4 [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition (sonic-net#2150) 90abc07 [config reload] Fix invalid rstrip. (sonic-net#2157) fac1769 Accept 0 for queue and dscp (sonic-net#2162) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
wen587
added a commit
that referenced
this pull request
Jun 13, 2022
29503ab [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel (#2151) ac89489 Modify override testcase to cover PORT admin_status (#2165) d7953d2 [GCU] Validate peer_group_range ip_range are correct (#2145) aa81b97 [auto-ts] add memory check (#2116) b370290 support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 (#2167) 87fc0a4 [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition (#2150) 90abc07 [config reload] Fix invalid rstrip. (#2157) fac1769 Accept 0 for queue and dscp (#2162)
This was referenced Jun 17, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Originally only IPv4 loopback address is configured for IP decap. This change add IPv6 support, as well as extend the decap to front panel port IP, port channel IP and vlan IP as well.